Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-4881: support for truncated addresses #521

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

andreo141
Copy link
Collaborator

@andreo141 andreo141 commented Dec 16, 2024

Overview

This PR includes support for inserting truncated addresses.
A truncated address is an address without the zipcode and municipality name shown. These attributes are still encoded in hidden RDFa.

connected issues and PRs:

GN-4881

Setup

None

How to test/reproduce

  • Start the dummy app
  • Click on the 'Insert location' sidebar button
  • While filling in an address, ensure that you can select whether or not it should be inserted in a 'truncated' format
  • Ensure the truncated/non-truncated address format is persisted across document reloads

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma self-requested a review January 21, 2025 09:30
@elpoelma elpoelma force-pushed the simplify-location branch 2 times, most recently from 45da9fe to 3744c9b Compare January 21, 2025 15:19
@elpoelma elpoelma self-assigned this Jan 21, 2025
@elpoelma elpoelma marked this pull request as ready for review January 23, 2025 13:07
@elpoelma elpoelma changed the title Simplify location GN-4881: support for truncated addresses Jan 23, 2025
@elpoelma elpoelma added the enhancement New feature or request label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants