Issue3538 air2 air recovery #4088
Conversation
|
@JayHuLBL can you please review this PR? |
|
@SenHuang19 |
@JayHuLBL for some examples (e.g., |
Buildings/Fluid/HeatExchangers/ThermalWheels/Latent/Examples/SpaceCooling.mo
Outdated
Show resolved
Hide resolved
| @@ -86,12 +119,12 @@ corrections versus wheel speed ratio are correction factors that are multiplied | |||
| with the heat exchange effectiveness that the wheel has a full rotational speed. | |||
| </li> | |||
| <li> | |||
| When <code>haveLatentHeatExchange = true</code>, | |||
| When <code>haveLatentHeatExchange=true</code>, | |||
There was a problem hiding this comment.
Has the flag been used to enable/disable parameters? I didn't see it.
There was a problem hiding this comment.
no, it was not used. I fixed this issue.
| @@ -1,37 +1,71 @@ | |||
| within Buildings.Fluid.HeatExchangers.ThermalWheels.Data; | |||
| record Generic "Generic data record for variable-speed wheels" | |||
| record Generic "Generic data record for thermal wheels" | |||
There was a problem hiding this comment.
In the class Buildings.Fluid.HeatExchangers.ThermalWheels.Data.ASHRAE, please final haveVariableSpeed=true, as below. I believe the ASHRAE is only for the wheels with variable speed drive, right?
record ASHRAE = Buildings.Fluid.HeatExchangers.ThermalWheels.Data.Generic(
final haveVariableSpeed=true,
senHeatExchangeEffectiveness(With the change, when instantiating it, like in Buildings.Fluid.HeatExchangers.ThermalWheels.Latent.Validation.SpeedControlled, uses will not be able to change the value.
| "Part load (75% of the nominal supply flow rate) sensible heat exchanger effectiveness at the heating mode" | ||
| annotation (Dialog(group="Part load effectiveness")); | ||
| parameter Buildings.Fluid.HeatExchangers.ThermalWheels.Data.Generic per | ||
| "Record with performance data" |
There was a problem hiding this comment.
per(final haveLatentHeatExchange=false)
| "Part load (75% of the nominal supply mass flow rate) latent heat exchanger effectiveness at the heating mode" | ||
| annotation (Dialog(group="Part load effectiveness")); | ||
|
|
||
| parameter Buildings.Fluid.HeatExchangers.ThermalWheels.Data.Generic per |
There was a problem hiding this comment.
per(final haveLatentHeatExchange=true)
This is to address #3554 (review)