Add padding to left and right #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikBernhardt
changed the title
fingolfin
reviewed
Dec 21, 2019
stylesheets/styles.css
Outdated
| @@ -26,7 +26,7 @@ time, mark, audio, video { | |||
| /* Base text styles */ | |||
|
|
|||
| body { | |||
| padding:10px 50px 0 0; | |||
| padding:10px 50px 20px 20px; | |||
There was a problem hiding this comment.
But why is there such an asymmetric padding? Can we try with this:
Suggested change
| padding:10px 50px 20px 20px; | |
| padding:50px 50px 20px 20px; |
There was a problem hiding this comment.
@fingolfin I've pushed an update now. In my opinion, the space at the top of the page feels very big now. What do you say?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds padding both to the left and right.
Resolves #97