Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove via device from platforms #1470

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove via device from platforms #1470

wants to merge 2 commits into from

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Jan 5, 2025

fixes #1471

@drc38 drc38 temporarily deployed to continuous-integration January 5, 2025 19:36 — with GitHub Actions Inactive
@drc38 drc38 requested a review from lbbrhzn January 5, 2025 19:37
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (76287e5) to head (96f0215).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files          12       12           
  Lines        1943     1943           
=======================================
  Hits         1840     1840           
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@lbbrhzn lbbrhzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to remove the via, is it causing issues?
The via could be useful information if you have multiple instances of the integration.

@drc38
Copy link
Collaborator Author

drc38 commented Jan 8, 2025

Why do you want to remove the via, is it causing issues? The via could be useful information if you have multiple instances of the integration.

I don't believe it is necessary as the via_device is already set on being instantiated here

via_device=(DOMAIN, entry.data.get(CONF_CSID, DEFAULT_CSID)),
so then platforms simply need to associate with the device itself by way of its identifier.

@drc38 drc38 temporarily deployed to continuous-integration January 8, 2025 22:31 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

device_registry.async_get_or_create error
2 participants