Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing Google to always redirect to the English version #4

Closed
wants to merge 1 commit into from

Conversation

simevidas
Copy link

Seems to work on my machine. Please test first!

Seems to work on my machine. Please test first!
@lazd
Copy link
Owner

lazd commented Oct 25, 2013

This is a good start and fixes the issue for the majority of our users, but it's English centric. I've filed #5 for more robust language support using the Accept-Language header.

That said, I'll test/merge/deploy this, thanks for the PR!

@lazd
Copy link
Owner

lazd commented Jan 7, 2014

I tried to change my default Google search results language to Spanish, hoping to get the Spanish version of the Array.forEach docs, but it showed the English version regardless.

When I search normally on an account configured for Spanish, unfortunately, the English version appears above the Spanish version. With this as the case, it seems we can't get an easy shot at localization and that this PR might make things work better for our users, but I'm still not entirely sure.

@blakeembrey blakeembrey closed this Nov 7, 2019
@blakeembrey
Copy link
Collaborator

It's been a while and we just changed to DuckDuckGo. Could implement the same thing in the DuckDuckGo URL if it helps people though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants