-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move slick carousel theme to global #6164
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Shivam Gupta <[email protected]>
🚀 Preview for commit 9fdd79a at: https://677a7767dd610f577a0b6dc2--layer5.netlify.app |
@leecalcote @vishalvivekm @SAHU-01 can anyone please test with this pr if there still conflict warning ? |
@sudhanshutech I can't see this PR raising a conflict warning anymore. |
@vishalvivekm can you? |
I am waiting for others reviews here. |
Looking… |
@sudhanshutech, I don’t see a carousel in mobile view. Is this intentional? https://layer5.io/community |
I checked that page in desktop view as well and don't see a slider on the /community page... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorporate the latest slider package version - #6141
@leecalcote there is no slider at community currently its being commented out. Other pages which are using slider are few these:
they are working as expected |
Signed-off-by: Shivam Gupta <[email protected]>
🚀 Preview for commit e5a2549 at: https://677d1ef14c89e586e26cbe70--layer5.netlify.app |
the version is upgraded. |
Description
This PR moves the slick-carousel theme module from specific file to global or root level with font css module. Since font was earlier used in root level but slick-carousel theme was used as specific files that's why webpack was not able to generate the correct order to implement them.
Notes for Reviewers
Signed commits