Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pricing tier comparison headers #6138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krishkumar84
Copy link
Contributor

@krishkumar84 krishkumar84 commented Dec 31, 2024

Description

This PR fixes #6122

Notes for Reviewers
@leecalcote @Ajay-singh1 @sudhanshutech @vishalvivekm
kindly review this pr
iIn this PR, I made the pricing component header sticky, allowing the subscription tiers to remain visible throughout the scroll within the component

Uploading layer5.mp4…

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Dec 31, 2024

🚀 Preview for commit 766e6c2 at: https://6773d865644e61242176d16b--layer5.netlify.app

@Ajay-singh1
Copy link
Member

Hey! @krishkumar84 Can you see the margins between the table cell? It doesn't look good.Also can you make it look like this ....

Screencast.from.2024-12-31.18-53-44.mp4

@krishkumar84
Copy link
Contributor Author

krishkumar84 commented Dec 31, 2024

Hi @Ajay-singh1,

I have kept the design simple and aligned with the current site’s layout. The issue is about making the header sticky, which is why I haven't modified the styling of the table, as it is not necessary for this issue for design change we can create another issue ...

@Ajay-singh1
Copy link
Member

Ajay-singh1 commented Dec 31, 2024

Hi @Ajay-singh1,

I have kept the design simple and aligned with the current site’s layout. The issue is about making the header sticky, which is why I haven't modified the styling of the table, as it is not necessary for this issue for design change we can create another issue ...

Making the header sticky can be achieved quiet easily right?.We want the user experience to be good... make the necessary changes else everything is good.

@leecalcote leecalcote requested a review from SAHU-01 December 31, 2024 18:44
@leecalcote
Copy link
Member

Thank you for working on improving the site, gents.

@Ajay-singh1
Copy link
Member

Can't you see the borders?.
Screenshot_20250103-210841_Chrome

@krishkumar84
Copy link
Contributor Author

krishkumar84 commented Jan 3, 2025

hey @Ajay-singh1 can you tell me the exact changes i have to do in this like in border or something

@Ajay-singh1
Copy link
Member

@krishkumar84 Hmm....First you need to fix the borders do you see the black borders around table cells?
Screenshot from 2025-01-03 21-35-10
And make the table header look like this...

Screencast.from.2024-12-31.18-53-44.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Pricing] Make Tier Comparison Header Sticky
4 participants