refactor: CNS-1008 - Optimizer Refactor Part 1: provider optimizer refactor #1784
Conversation
…e() + minor test fix
Test Results1 043 tests 1 037 ✅ 11m 17s ⏱️ For more details on these failures and errors, see this check. Results for commit 62048d5. ♻️ This comment has been updated with latest results. |
oren-lava
changed the title
oren-lava
changed the title
| // | ||
| // Important: when using this function from the node's code, do not configure the block error probability | ||
| // (in default mode, it's unused) | ||
| func (qos *QualityOfServiceReport) ComputeQoSExcellence(opts ...Option) (sdk.Dec, error) { |
There was a problem hiding this comment.
need to merge latest reputation here
| utils.LogAttr("provider", providerAddress), | ||
| utils.LogAttr("requested_block", requestedBlock), | ||
| ) | ||
| return NewSelectionTier(), Exploration{}, nil |
There was a problem hiding this comment.
this will error out on earliest requests etc, let's treat them as latest in that case
| AvailabilityScore: providerData.Availability.Num / providerData.Availability.Denom, | ||
| LatencyScore: latencyScoreCurrent, | ||
| GenericScore: providerScore, | ||
| SyncScore: qos.Sync.MustFloat64(), |
There was a problem hiding this comment.
if case this panics the entire service will go down due to some error, this is very strict
in general we hardly panic and FATAL on code that isnt performed on startup
the correct approach is to do a severe error, and return default values that allow you to move on
| syncScore = sdk.OneDec() | ||
| if sync == 0 { | ||
| // if our sync score is uninitialized due to lack of providers | ||
| sync = 1 |
There was a problem hiding this comment.
in general this is penalising perfect providers but 1 is a very low number so i am okay with this, can add a comment explaining that this is 1ms delay
Description
Closes: #XXXX
I refactored the provider optimizer and fixed various bugs it had. I did the refactor in files with "_refator" suffix to be able to test the new optimizer while not hurting the current one
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...