Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Acquire for PgListener #3550

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

sandhose
Copy link
Contributor

@sandhose sandhose commented Oct 8, 2024

Does your PR solve an issue?

Fixes #3549

@CommanderStorm
Copy link
Contributor

(not a maintainer)
Could you add a testcase to ensure that this continues to work in the future? ^^

@sandhose
Copy link
Contributor Author

sandhose commented Oct 9, 2024

(not a maintainer) Could you add a testcase to ensure that this continues to work in the future? ^^

Good suggestion, I've just added that!

Copy link
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

sqlx-postgres/src/listener.rs Outdated Show resolved Hide resolved
@sandhose sandhose requested a review from abonander October 23, 2024 16:09
@sandhose
Copy link
Contributor Author

@abonander Looks like the name of the test channel was conflicting with another test. I changed it and looks like it's working, at least locally

@sandhose sandhose requested a review from abonander October 28, 2024 14:16
@abonander abonander merged commit 709226c into launchbadge:main Oct 28, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a way to borrow the connection out of a PgListener
3 participants