Generic Associated Types in Database, replacing HasValueRef, HasArguments, HasStatement #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitn3lav
changed the title
nitn3lav
changed the title
|
This is a refactor I've been dreading having to do, I really appreciate it. |
|
@nitn3lav can you rebase and fix the conflict? We're ready to merge breaking changes now. |
replace the associated types from the generic traits `HasValueRef<'r>`, `HasArguments<'q>` and `HasStatement<'q>` with generic associated types in `Database`
abonander
force-pushed
the
db-gat
branch
2 times, most recently
from
897f55b to
39c7190
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces the associated types from the generic traits
HasValueRef<'r>,HasArguments<'q>andHasStatement<'q>with generic associated types inDatabase, as described in the (now removed) comment:This is obviously a breaking change.
GATs have been stable since Rust 1.65