Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WeekDay and Month enumerators public for time and chrono features #2904

Closed
wants to merge 2 commits into from

Conversation

Luni-4
Copy link

@Luni-4 Luni-4 commented Nov 27, 2023

Without making Weekday and Month enumerators public for time and chrono features, it gets hard to retrieve week information when either a date or a timestamp is saved within a Postgres database.

This PR exports:

  • Weekday and Month for time crate
  • Weekday for chrono crate

Thanks in advance for your review!

@Luni-4 Luni-4 force-pushed the export-time-crates branch from 1b273f1 to ce665ed Compare November 27, 2023 10:52
@abonander
Copy link
Collaborator

SQLx only reexports the types that it actually needs to function. You should just add time or chrono to your dependencies and import from there.

@abonander abonander closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants