Merge pull request #570 from laughingman7743/fix_type_hints

Fix type hints
laughingman7743 · Dec 28, 2024 · b8fac65 · b8fac65
2 parents 2ca949b + 5b20fcf
commit b8fac65
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/pyathena/async_cursor.py b/pyathena/async_cursor.py
@@ -97,7 +97,7 @@ def _collect_result_set(self, query_id: str) -> AthenaResultSet:
     def execute(
         self,
         operation: str,
-        parameters: Optional[Dict[str, Any]] = None,
+        parameters: Optional[Union[Dict[str, Any], List[str]]] = None,
         work_group: Optional[str] = None,
         s3_staging_dir: Optional[str] = None,
         cache_size: Optional[int] = 0,

diff --git a/pyathena/pandas/cursor.py b/pyathena/pandas/cursor.py
@@ -182,7 +182,10 @@ def execute(
         return self
 
     def executemany(
-        self, operation: str, seq_of_parameters: List[Optional[Dict[str, Any]]], **kwargs
+        self,
+        operation: str,
+        seq_of_parameters: List[Optional[Union[Dict[str, Any], List[str]]]],
+        **kwargs,
     ) -> None:
         for parameters in seq_of_parameters:
             self.execute(operation, parameters, **kwargs)

diff --git a/pyathena/spark/common.py b/pyathena/spark/common.py
@@ -217,7 +217,10 @@ def close(self) -> None:
         self._terminate_session()
 
     def executemany(
-        self, operation: str, seq_of_parameters: List[Optional[Dict[str, Any]]], **kwargs
+        self,
+        operation: str,
+        seq_of_parameters: List[Optional[Union[Dict[str, Any], List[str]]]],
+        **kwargs,
     ) -> None:
         raise NotSupportedError
 

diff --git a/pyathena/sqlalchemy/util.py b/pyathena/sqlalchemy/util.py
@@ -2,5 +2,5 @@
 
 
 class _HashableDict(dict):  # type: ignore
-    def __hash__(self):
+    def __hash__(self):  # type: ignore
         return hash(tuple(sorted(self.items())))