added functionality to latch test-data upload #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the option to specify destination folder to write test-data to
|
Related to this issue: #187 |
ayushkamat
requested changes
Dec 16, 2022
|
|
||
| from latch_cli.services.test_data.utils import _retrieve_creds | ||
| from latch_cli.utils import account_id_from_token, retrieve_or_login | ||
|
|
||
| BUCKET = "latch-public" | ||
|
|
||
|
|
||
| def upload(src_path: str, dont_confirm_overwrite: bool = True) -> str: | ||
| def upload(src_path: str, s3_path: str = None, dont_confirm_overwrite: bool = True) -> str: |
There was a problem hiding this comment.
Suggested change
| def upload(src_path: str, s3_path: str = None, dont_confirm_overwrite: bool = True) -> str: | |
| def upload(src_path: str, s3_path: Optional[str] = None, dont_confirm_overwrite: bool = True) -> str: |
using the Optional type from typing makes this more semantic
| @@ -506,6 +506,11 @@ def test_data(ctx): | |||
|
|
|||
| @test_data.command("upload") | |||
| @click.argument("src_path", nargs=1, type=click.Path(exists=True)) | |||
| @click.option( | |||
| "--s3_path", | |||
There was a problem hiding this comment.
Suggested change
| "--s3_path", | |
| "--s3-path", |
kebab-case for cli options
| @click.option( | ||
| "--s3_path", | ||
| default = None, | ||
| type=str, |
There was a problem hiding this comment.
can you make this optional as well (see my other comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to specify a destination folder on s3 when uploading test-data.
For example:
latch test-data upload./matrix.mtx --s3_path test/matrix.mtxwill write tos3://latch-public/test-data/4751/test/matrix.mtx.If you don't specify
--s3_path, it will write to the same path as the local path. Default functionality remains the same.