Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shell variant detection for shfmt #245

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rolandmas
Copy link

This adds a suffix to the filename passed to shfmt so it can use the default settings stored in .editorconfig even for shell scripts without an extension.

@lassik
Copy link
Owner

lassik commented Oct 20, 2023

Thanks. A better approach is to always use -ln instead of using fake filenames.

@lassik
Copy link
Owner

lassik commented Oct 20, 2023

I can write the code.

@lassik
Copy link
Owner

lassik commented Oct 20, 2023

Wait, editorconfig. Isn't it supposed to be based on filename patterns only? So if you want to use editoconfig settings for foo, you have to write a [foo] section in the .editorconfig file?

@rolandmas
Copy link
Author

Yes, correct. Which is why I needed to write a section for [.sh] and [.bash] in that file in order to save default settings for shfmt; and using -ln only doesn't cause shfmt to read these sections because it's based on filenames, hence the tweak in -filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants