Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Clear resolved Vite instance (via Facade) to avoid memory-leak" #994

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Revert "Clear resolved Vite instance (via Facade) to avoid memory-leak" #994

merged 1 commit into from
Feb 10, 2025

Conversation

taylorotwell
Copy link
Member

Reverts #993

@taylorotwell taylorotwell merged commit 27a54d2 into 2.x Feb 10, 2025
4 of 5 checks passed
@taylorotwell taylorotwell deleted the revert-993-issue-992 branch February 10, 2025 10:59
@markieo1
Copy link

Is there a reason for the revert? We are currently seeing the following issue:

Unable to locate file in Vite manifest: src/app.js

And are wondering if this has something to do with this?

@crynobone
Copy link
Member

The changes was never released on Octane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylorotwell @markieo1 @crynobone