Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Add default styles to several views. #756

Closed
wants to merge 1 commit into from

Conversation

jm-observer
Copy link
Contributor

No description provided.

@jrmoulton
Copy link
Collaborator

It might be better to just have the PointerEventsProp not be wrapped in None.

What behavior does this change? Why these views specifically?

@jm-observer
Copy link
Contributor Author

It might be better to just have the PointerEventsProp not be wrapped in None.

What behavior does this change? Why these views specifically?

While troubleshooting the click event, I found that the is_pointer_none of these views is being calculated as true, but I’m not sure why.

#context.rs
        let is_pointer_none = event.is_pointer()
            && view_state.borrow().computed_style.get(PointerEventsProp)
                == Some(PointerEvents::None);

@jrmoulton
Copy link
Collaborator

Floem doesn't default any views to use Some(PointerEvents::None). Doing a symbol search confirms that so, if that is true, I don't think these changes belong in Floem.

@jm-observer jm-observer closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants