move def_en and def_v to CPP file to fix minor linking issue with singularity-eos-extra #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When adding a fortran interface to singularity-eos-extra, the
singularity_eos_init_utils.hpp
header is needed. However, it definesdef_en
anddef_v
in global scope in a header file. This produces linking errors when using plugins. Here I resolve the linking error by simply moving the definition of these arrays intosingularity_eos.cpp
but still make them "available" by declaring them asextern
in the original header.@dholladay00 should I declare them constant?
PR Checklist
make format
command after configuring withcmake
.If preparing for a new release, in addition please check the following:
when='@main'
dependencies are updated to the release version in the package.py