Skip to content

Commit

Permalink
Merge pull request #262 from nicolasbock/openmp_5
Browse files Browse the repository at this point in the history
Openmp 5.0 and gcc-9
  • Loading branch information
nicolasbock authored Jun 26, 2019
2 parents e0cc860 + 3f38bf6 commit a4d3a54
Show file tree
Hide file tree
Showing 39 changed files with 121 additions and 164 deletions.
96 changes: 41 additions & 55 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,6 @@ cache:
- "/home/travis/.nvm"
- "/home/travis/.rvm"

env:
global:
- OMP_NUM_THREADS=4
- CMAKE_BUILD_TYPE=Debug
- VERBOSE_MAKEFILE=yes
- PARALLEL_TEST_JOBS=2
- DEVEL_PACKAGES="cmake cmake-data libblas-dev liblapack-dev"
# COVERTY_SCAN_TOKEN
- secure: tWwP7P4ytNISAZIP9IXGTLW+VJjtMzokJvBXWpvOM6y3ard0ZXQs4z5nna4vU4oeYkXZ1hJ8LIL2K5weDflnLP4QWoPBPOduWNPWnZq/PGV0wwtVsE9PqHIGIpQ/+v3pKwRkWIjAyhELBH2cxqYGKA5wDrk3moHXqn8SnZObLkbdRJrixtvODfKI9FOpNt2USFn7y7G9C+iNJ+OUbD5wn6JGg1EACwO9Fef6IULDpZHTgAMZjjXL8buhAshCSTkF9o13qiHr/A7aVZOB/zI357ydfqFTyYdRGPEcpX/WOalGg047dQCNR95Qm9QgLNPN6RoTo/9nK1Nba5xVrUJiFTWSH9YUv4iklzZHbDSrAb1vWwVtWVKNGF47m/3NvI3QsXAb0na79g4vKfgTJB2hCQpezlZua2wtOvvcPJ76j5aEKAmdLqaTl1jQyCX2mLOv3iywUmXtIsHwdxZkWGixpdJie6EnNpo72tIj8PlqMHi+viEtnNrItG/h92leDKLBvLZGwmwhl08fMMLz+O7sHkjGbTCBUeMffHOnTvWoRvTMB3qCk6SibcgEYw3TrV1ubctSxkJkKBVHWoOum8a+VoPQOfmoQ1b55M4Xh6W2dGzncqy0OsQKBXVHtz+dHFr6AZsXiLEzMhqtuP6WquLHuZPJ3PsJjlxi/RHwOgeR57g=

addons:
apt:
update: true
Expand All @@ -43,11 +33,36 @@ deploy:
on:
tags: true

env:
global:
- OMP_NUM_THREADS=4
- CMAKE_BUILD_TYPE=Debug
- VERBOSE_MAKEFILE=yes
- PARALLEL_TEST_JOBS=2
- DEVEL_PACKAGES="cmake cmake-data libblas-dev liblapack-dev"
# COVERTY_SCAN_TOKEN
- secure: tWwP7P4ytNISAZIP9IXGTLW+VJjtMzokJvBXWpvOM6y3ard0ZXQs4z5nna4vU4oeYkXZ1hJ8LIL2K5weDflnLP4QWoPBPOduWNPWnZq/PGV0wwtVsE9PqHIGIpQ/+v3pKwRkWIjAyhELBH2cxqYGKA5wDrk3moHXqn8SnZObLkbdRJrixtvODfKI9FOpNt2USFn7y7G9C+iNJ+OUbD5wn6JGg1EACwO9Fef6IULDpZHTgAMZjjXL8buhAshCSTkF9o13qiHr/A7aVZOB/zI357ydfqFTyYdRGPEcpX/WOalGg047dQCNR95Qm9QgLNPN6RoTo/9nK1Nba5xVrUJiFTWSH9YUv4iklzZHbDSrAb1vWwVtWVKNGF47m/3NvI3QsXAb0na79g4vKfgTJB2hCQpezlZua2wtOvvcPJ76j5aEKAmdLqaTl1jQyCX2mLOv3iywUmXtIsHwdxZkWGixpdJie6EnNpo72tIj8PlqMHi+viEtnNrItG/h92leDKLBvLZGwmwhl08fMMLz+O7sHkjGbTCBUeMffHOnTvWoRvTMB3qCk6SibcgEYw3TrV1ubctSxkJkKBVHWoOum8a+VoPQOfmoQ1b55M4Xh6W2dGzncqy0OsQKBXVHtz+dHFr6AZsXiLEzMhqtuP6WquLHuZPJ3PsJjlxi/RHwOgeR57g=
matrix:
- CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=no
- CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=yes
- CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=no
- CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=yes
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=no BML_OPENMP=no BML_INTERNAL_BLAS=no BML_VALGRIND=yes packages="valgrind"
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=no BML_OPENMP=no BML_INTERNAL_BLAS=yes
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=no BML_OPENMP=yes BML_INTERNAL_BLAS=no
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=no BML_OPENMP=yes BML_INTERNAL_BLAS=yes
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=no
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=yes
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=no
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=yes

script:
- ./install_packages.sh
- ./build.sh testing

stages:
- name: linter
if: branch != coverty_scan
- name: test-full
if: branch != coverty_scan
- name: coverage
if: branch != coverty_scan
- name: docs
Expand All @@ -58,61 +73,32 @@ stages:
jobs:
include:
- stage: linter
name: "Linter"
script:
- bundle install
- pip install proselint
- bundle exec danger
- env packages="indent" ./install_packages.sh
- env BML_OPENMP=no VERBOSE_MAKEFILE=yes ./build.sh check_indent
- packages="indent" ./install_packages.sh
- BML_OPENMP=no VERBOSE_MAKEFILE=yes ./build.sh check_indent
- stage: docs
name: "Build Docs"
env:
- CC=gcc-9 CXX=g++-9 FC=gfortran-9 BML_OPENMP=no VERBOSE_MAKEFILE=yes packages="doxygen texlive"
script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8 doxygen texlive" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BML_OPENMP=no VERBOSE_MAKEFILE=yes ./build.sh docs
- stage: test
script:
- env packages="${DEVEL_PACKAGES} gcc-4.7 g++-4.7 gfortran-4.7" ./install_packages.sh
- env CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 GCOV=gcov-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=no ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-4.7 g++-4.7 gfortran-4.7" ./install_packages.sh
- env CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 GCOV=gcov-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=yes ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-4.7 g++-4.7 gfortran-4.7" ./install_packages.sh
- env CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 GCOV=gcov-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=no ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-4.7 g++-4.7 gfortran-4.7" ./install_packages.sh
- env CC=gcc-4.7 CXX=g++-4.7 FC=gfortran-4.7 GCOV=gcov-4.7 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=yes ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} valgrind gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=no BML_OPENMP=no BML_INTERNAL_BLAS=no ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=no BML_OPENMP=no BML_INTERNAL_BLAS=yes ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=no BML_OPENMP=yes BML_INTERNAL_BLAS=no ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=no BML_OPENMP=yes BML_INTERNAL_BLAS=yes ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=no ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=yes BML_OPENMP=no BML_INTERNAL_BLAS=yes ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=no ./build.sh testing
- script:
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=yes ./build.sh testing
- ./install_packages.sh
- ./build.sh docs
- stage: coverage
name: "Get test coverage"
env:
- CC=gcc-7 CXX=g++-7 FC=gfortran-7 GCOV=gcov-7 BUILD_SHARED_LIBS=yes BML_COVERAGE=yes BML_OPENMP=yes BML_INTERNAL_BLAS=yes
script:
- pip install cpp-coveralls codecov
- env packages="${DEVEL_PACKAGES} gcc-8 g++-8 gfortran-8" ./install_packages.sh
- env CC=gcc-8 CXX=g++-8 FC=gfortran-8 GCOV=gcov-8 BUILD_SHARED_LIBS=yes BML_OPENMP=yes BML_INTERNAL_BLAS=yes ./build.sh testing
- ./install_packages.sh
- ./build.sh testing
after_success:
- codecov --gcov-exec ${GCOV}
- coveralls
- stage: coverty
name: "Run coverty"
before_install:
- echo -n | openssl s_client -connect https://scan.coverity.com:443 | sed -ne '/-BEGIN CERTIFICATE-/,/-END CERTIFICATE-/p' | sudo tee -a /etc/ssl/certs/ca-
13 changes: 10 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ else()
endif()

set(GNU_C_FLAGS_DEBUG -O0 -g -Wall -Wimplicit -Werror=implicit
-Wunused-variable -Wno-unknown-pragmas --coverage -save-temps -std=c99)
-Wunused-variable -Wno-unknown-pragmas -save-temps -std=c99)
set(GNU_C_FLAGS_RELEASE -O3 -g -std=c99 -DNDEBUG)
set(GNU_C_FLAGS_RELWITHDEBINFO -O3 -g -std=c99 -DNDEBUG)
set(GNU_Fortran_FLAGS_DEBUG -O0 -g --coverage -fcheck=all
Expand Down Expand Up @@ -155,6 +155,11 @@ else()
message(STATUS "Will not build with OpenMP")
endif()

set(BML_COVERAGE FALSE CACHE BOOL "Whether to generate coverage code")
if(BML_COVERAGE)
set(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} --coverage)
endif()

set(BML_MPI FALSE CACHE BOOL "Compile with MPI support")
if(BML_MPI)
message(STATUS "Will build with MPI")
Expand Down Expand Up @@ -519,13 +524,15 @@ endif()

set(BML_TESTING FALSE
CACHE BOOL "Whether to build the test suite.")
set(BML_VALGRIND FALSE
CACHE BOOL "Whether to test for memory leaks with valgrind")

if(BML_TESTING)
message(STATUS "Setting up test suite")
find_program(VALGRIND valgrind
DOC "valgrind - a suite of tools for debugging and profiling programs")
if(VALGRIND)
message(STATUS "Found valgrind, will test memory")
if(VALGRIND AND BML_VALGRIND)
message(STATUS "Will test for memory leaks")
endif()
enable_testing()
if(BML_OLD)
Expand Down
6 changes: 6 additions & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ EOF
echo "BML_MPI {yes,no} (default is ${BML_MPI})"
echo "BML_COMPLEX {yes,no} (default is ${BML_COMPLEX})"
echo "BML_TESTING {yes,no} (default is ${BML_TESTING})"
echo "BML_VALGRIND {yes,no} (default is ${BML_VALGRIND})"
echo "BML_COVERAGE {yes,no} (default is ${BML_COVERAGE})"
echo "BUILD_DIR Path to build dir (default is ${BUILD_DIR})"
echo "BLAS_VENDOR {,Intel,MKL,ACML,GNU,IBM,Auto} (default is '${BLAS_VENDOR}')"
echo "BML_INTERNAL_BLAS {yes,no} (default is ${BML_INTERNAL_BLAS})"
Expand Down Expand Up @@ -84,6 +86,8 @@ set_defaults() {
: ${CMAKE_CXX_FLAGS:=}
: ${CMAKE_Fortran_FLAGS:=}
: ${BML_TESTING:=yes}
: ${BML_VALGRIND:=no}
: ${BML_COVERAGE:=no}
: ${FORTRAN_FLAGS:=}
: ${EXTRA_LINK_FLAGS:=}
: ${BML_GPU:=no}
Expand Down Expand Up @@ -148,6 +152,8 @@ configure() {
-DBML_COMPLEX="${BML_COMPLEX}" \
-DBUILD_SHARED_LIBS="${BUILD_SHARED_LIBS}" \
-DBML_TESTING="${BML_TESTING:=yes}" \
-DBML_VALGRIND="${BML_VALGRIND:=no}" \
-DBML_COVERAGE="${BML_COVERAGE:=no}" \
-DBLAS_VENDOR="${BLAS_VENDOR}" \
-DBML_INTERNAL_BLAS="${BML_INTERNAL_BLAS}" \
${EXTRA_CFLAGS:+-DEXTRA_CFLAGS="${EXTRA_CFLAGS}"} \
Expand Down
2 changes: 1 addition & 1 deletion install_packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ for i in $(seq 5); do
if ! sudo apt-get update; then
continue
fi
if sudo apt-get install ${packages}; then
if sudo apt-get install --no-install-recommends ${DEVEL_PACKAGES} ${CC} ${CXX} ${FC} ${packages}; then
exit 0
fi
done
Expand Down
2 changes: 0 additions & 2 deletions src/C-interface/dense/bml_add_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ double TYPED_FUNC(
int *A_localRowMax = A->domain->localRowMax;

#pragma omp parallel for \
default(none) \
shared(B_matrix, A_localRowMin, A_localRowMax) \
shared(N, myRank) \
reduction(+:trnorm)
Expand Down Expand Up @@ -146,7 +145,6 @@ void TYPED_FUNC(
int myRank = bml_getMyRank();

#pragma omp parallel for \
default(none) \
shared(A_matrix, A_localRowMin, A_localRowMax) \
shared(N, myRank, beta_)
//for (int i = 0; i < N; i++)
Expand Down
4 changes: 2 additions & 2 deletions src/C-interface/dense/bml_adjungate_triangle_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void TYPED_FUNC(
switch (*triangle)
{
case 'u':
#pragma omp parallel for default(none) shared(N, A_matrix)
#pragma omp parallel for shared(N, A_matrix)
for (int i = 0; i < N - 1; i++)
{
for (int j = i + 1; j < N; j++)
Expand All @@ -48,7 +48,7 @@ void TYPED_FUNC(
break;

case 'l':
#pragma omp parallel for default(none) shared(N, A_matrix)
#pragma omp parallel for shared(N, A_matrix)
for (int i = 0; i < N - 1; i++)
{
for (int j = i + 1; j < N; j++)
Expand Down
4 changes: 2 additions & 2 deletions src/C-interface/dense/bml_allocate_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ bml_matrix_dense_t *TYPED_FUNC(
bml_matrix_dense_t *A =
TYPED_FUNC(bml_zero_matrix_dense) (matrix_dimension, distrib_mode);
REAL_T *A_dense = A->matrix;
#pragma omp parallel for default(none) shared(A_dense)
#pragma omp parallel for shared(A_dense)
for (int i = 0; i < N; i++)
{
for (int j = (i - M / 2 >= 0 ? i - M / 2 : 0);
Expand Down Expand Up @@ -200,7 +200,7 @@ bml_matrix_dense_t *TYPED_FUNC(
REAL_T *A_dense = A->matrix;
#endif

#pragma omp parallel for default(none) shared(A_dense)
#pragma omp parallel for shared(A_dense)
for (int i = 0; i < N; i++)
{
#ifdef BML_USE_MAGMA
Expand Down
6 changes: 2 additions & 4 deletions src/C-interface/dense/bml_norm_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ double TYPED_FUNC(

int myRank = bml_getMyRank();

#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix) \
shared(A_localRowMin, A_localRowMax, myRank) \
reduction(+:sum)
Expand Down Expand Up @@ -123,7 +123,7 @@ double TYPED_FUNC(

REAL_T *A_matrix = A->matrix;

#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix) \
reduction(+:sum)
for (int i = 0; i < core_size * N; i++)
Expand Down Expand Up @@ -194,7 +194,6 @@ double TYPED_FUNC(
int myRank = bml_getMyRank();

#pragma omp parallel for \
default(none) \
shared(alpha_, beta_) \
shared(N, A_matrix, B_matrix) \
shared(A_localRowMin, A_localRowMax, myRank) \
Expand Down Expand Up @@ -281,7 +280,6 @@ double TYPED_FUNC(
int myRank = bml_getMyRank();

#pragma omp parallel for \
default(none) \
shared(temp) \
shared(N, A_matrix, B_matrix) \
shared(A_localRowMin, A_localRowMax, myRank) \
Expand Down
2 changes: 0 additions & 2 deletions src/C-interface/dense/bml_normalize_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ void *TYPED_FUNC(
#endif

#pragma omp parallel for \
default(none) \
shared(N, A_matrix) \
shared(A_localRowMin, A_localRowMax, myRank) \
private(absham, radius, dvalue) \
Expand Down Expand Up @@ -161,7 +160,6 @@ void *TYPED_FUNC(
double *eval = bml_allocate_memory(sizeof(double) * 2);

#pragma omp parallel for \
default(none) \
shared(N, A_matrix) \
private(absham, radius, dvalue) \
reduction(max:emax) \
Expand Down
4 changes: 2 additions & 2 deletions src/C-interface/dense/bml_threshold_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ bml_matrix_dense_t *TYPED_FUNC(

int myRank = bml_getMyRank();

#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix, B_matrix) \
shared(A_localRowMin, A_localRowMax, myRank)
//for (int i = 0; i < N * N; i++)
Expand Down Expand Up @@ -88,7 +88,7 @@ void TYPED_FUNC(

int myRank = bml_getMyRank();

#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix) \
shared(A_localRowMin, A_localRowMax, myRank)
//for (int i = 0; i < N * N; i++)
Expand Down
4 changes: 2 additions & 2 deletions src/C-interface/dense/bml_trace_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ double TYPED_FUNC(

int myRank = bml_getMyRank();

#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix) \
shared(A_localRowMin, A_localRowMax, myRank) \
reduction(+:trace)
Expand Down Expand Up @@ -108,7 +108,7 @@ double TYPED_FUNC(
("bml_traceMult_dense: Matrices A and B are different sizes.");
}

#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix, B_matrix) \
shared(A_localRowMin, A_localRowMax, myRank) \
reduction(+:trace)
Expand Down
4 changes: 2 additions & 2 deletions src/C-interface/dense/bml_transpose_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ bml_matrix_dense_t *TYPED_FUNC(
MAGMABLAS(transpose) (A->N, A->N, A->matrix, A->ld,
B->matrix, B->ld, A->queue);
#else
#pragma omp parallel for default(none) \
#pragma omp parallel for \
shared(N, A_matrix, B_matrix) \
shared(A_localRowMin, A_localRowMax, myRank)
//for (int i = 0; i < N; i++)
Expand Down Expand Up @@ -84,7 +84,7 @@ void TYPED_FUNC(
REAL_T *A_matrix = A->matrix;
REAL_T tmp;

#pragma omp parallel for default(none) \
#pragma omp parallel for \
private(tmp) \
shared(N, A_matrix)
for (int i = 0; i < N - 1; i++)
Expand Down
4 changes: 2 additions & 2 deletions src/C-interface/dense/bml_transpose_triangle_dense_typed.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ void TYPED_FUNC(
switch (triangle)
{
case 'u':
#pragma omp parallel for default(none) shared(N, A_matrix)
#pragma omp parallel for shared(N, A_matrix)
for (int i = 0; i < N - 1; i++)
{
for (int j = i + 1; j < N; j++)
Expand All @@ -47,7 +47,7 @@ void TYPED_FUNC(
break;

case 'l':
#pragma omp parallel for default(none) shared(N, A_matrix)
#pragma omp parallel for shared(N, A_matrix)
for (int i = 0; i < N - 1; i++)
{
for (int j = i + 1; j < N; j++)
Expand Down
Loading

0 comments on commit a4d3a54

Please sign in to comment.