Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixs on jtlaune/nu-disk #52

Open
wants to merge 54 commits into
base: jtlaune/nu-disk
Choose a base branch
from
Open

fixs on jtlaune/nu-disk #52

wants to merge 54 commits into from

Conversation

smao-astro
Copy link

Background

This is the same goal/feature as branch jtlaune/nu-disk. I fixed some bugs in the original branch.

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@adamdempsey90
Pass units to dust initialize so that we can convert input size and d…
b2bb443 
…ensity from cgs to problem units
@adamdempsey90
Update dust params
f61a958
@adamdempsey90
Update singularity eos
1586510
@adamdempsey90
Add generated directory to singularity include path
d0767c3
@adamdempsey90
remove input_units
5346481
@adamdempsey90
Merge remote-tracking branch 'origin/develop' into dempsey/dust_update
72984f6
@adamdempsey90
Merge pull request lanl#43 from lanl/dempsey/dust_update
b9e1093 
Convert dust params from cgs
@adamdempsey90
Merge pull request lanl#44 from lanl/dempsey/singularity
6c2a7a8 
Update singularity-eos
@adamdempsey90
Silence sprintf warning on mac. Correctly bake rpath info for rebound…
c134eb0 
… into mac
@adamdempsey90
Remove unnecessary set_target_properties since we now just do it manu…
a412b54 
…ally with install_name_tool
@adamdempsey90
Add BUILD_RPATH back
07b8d2a
@adamdempsey90
Do not move rebound around
0695404
@adamdempsey90
Merge branch 'dempsey/cmake_mac' of github.com:lanl/artemis into demp…
bc4e652 
…sey/cmake_mac
@adamdempsey90
Add temperature to units. Add temperature conversion factor to consta…
861a489 
…nts. Have base unit specifiers be built on top of preset base values
@adamdempsey90
Unit system aware singularity eos
1beaf57
@adamdempsey90
Add temperature conversion to opacities.
633ab21
@adamdempsey90
Add temperature unit to splash
cf6fce2
@adamdempsey90
Revert allowing setting of base scale factors in non base specifiers
02d61f1
@adamdempsey90
Update params for new temperature unit
94f09a4
@adamdempsey90
Merge pull request lanl#47 from lanl/dempsey/units
4a4f0f3 
Add temperature to units and have units aware EOS
@adamdempsey90
Merge branch 'develop' into dempsey/cmake_mac
7caffff
@adamdempsey90
Merge pull request lanl#46 from lanl/dempsey/cmake_mac
bf19cdb 
Fix rebound on mac
@adamdempsey90
Convert to cgs
e1e7527
@adamdempsey90
Add powerlaw opacity
335fad8
@adamdempsey90
Remove unphysical opacity models. Add powerlaw model
ea5f638
@adamdempsey90
Remove unused variables from pack
f05b652
@adamdempsey90
Cgs units
f12bc7e
@adamdempsey90
Update parameters
6094b1b
@adamdempsey90
Update parthenon to fix jaybenne problem
f1d3ff9
@adamdempsey90
Store mu and cv in params
a1c4de3
adamdempsey90 and others added 24 commits January 23, 2025 10:11
@adamdempsey90
Go to true cgs
ef426a4
@adamdempsey90
Update citation
3818e0f
@adamdempsey90
Update to v4 of upload/download artifacts
4008bb9
Add a thermal relaxation test
bd93848
Format new test
5bca683
Add rad_shock test to CI
0601078
Add the exact solution computed by Quokka script
d7818dc
Include new radiation tests in serial suite
6aee8d3
Don't use LaTex formatting for CI artifacts
051d92a
@smao-astro
Merge branch 'develop' into nu-disk
0ea4438
@smao-astro
merge env/bash from develop
05ad586
@smao-astro
remove unused lines
dcbc9c3
@smao-astro
add comments to drag.hpp
31c2762
@adamdempsey90
CartToSph returns ex1,ex2,ex3, not er,et,ep
578c823
@adamdempsey90
Merge pull request lanl#48 from lanl/dempsey/rad_cgs
2cf920d 
Convert radiation problems to cgs
@adamdempsey90
Merge remote-tracking branch 'origin/develop' into dempsey/sink
edf179b
@adamdempsey90
Merge pull request lanl#51 from lanl/dempsey/sink
db7c9dd 
BugFix for sinks
@smao-astro
merging nudisk into disk pgen
597b19e
@smao-astro
fix typo
3472d31
@smao-astro
fix error: identifier vd is undefined
ceedabf
@smao-astro
fix bug
ede9a20
@smao-astro
move vk2 outside if block
c133e84
@smao-astro
fix bug
61f69f7
@smao-astro
Merge remote-tracking branch 'origin/develop' into nu-disk
016198d
@adamdempsey90 adamdempsey90 changed the base branch from develop to jtlaune/nu-disk February 5, 2025 18:30
@adamdempsey90
Copy link
Collaborator

I changed this to point into JT's branch, rather than develop. You two can iterate together on his branch and when that's ready we can consider merging into develop

@adamdempsey90 adamdempsey90 requested a review from jtlaune February 5, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtlaune jtlaune Awaiting requested review from jtlaune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smao-astro @adamdempsey90