Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix for sinks #51

Merged
merged 2 commits into from
Feb 4, 2025
Merged

BugFix for sinks #51

merged 2 commits into from
Feb 4, 2025

Conversation

adamdempsey90
Copy link
Collaborator

Background

I assumed CartToSph returned the spherical unit vectors when, in fact, it returns the cartesian ones.

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@shengtai
Copy link
Collaborator

shengtai commented Feb 4, 2025

approved

@adamdempsey90 adamdempsey90 merged commit db7c9dd into develop Feb 4, 2025
4 checks passed
@adamdempsey90 adamdempsey90 deleted the dempsey/sink branch February 4, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

@shengtai shengtai Awaiting requested review from shengtai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdempsey90 @shengtai @pdmullen