add parse_meminfo() to avoid chopping MemFree/MemTotal info #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: On current system the avail memory was truncated when parsing the meminfo data, which made HBM device look like it only had a fraction of available memory. Signed-off-by: Thomas Naughton <[email protected]>
|
I noticed difference between system "MemFree" and SICM "avail" for devices. This patch fixes that, but needs more testing. Here are the logs before/after to show the problem/fix for my tests. Example of problem for numa node 0 (dram device) and 252 (hbm device): Example of "fix" for numa ndoe 0 (dram device) and 252 (hbm device): |
Signed-off-by: Thomas Naughton <[email protected]>
Signed-off-by: Thomas Naughton <[email protected]>
|
@lionkov I removed the DBG printfs. Note, I only did minor testing of this code for current use case/test environment. |
naughtont3
changed the title
naughtont3
changed the title
lionkov
approved these changes
Sep 23, 2020
lionkov
approved these changes
Sep 23, 2020
lionkov
approved these changes
Sep 23, 2020
|
Note: It appears this was a known issue (#49). The old method may be better. I'm just adding this note b/c I did not see Ben's ticket when I submitted my change. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: On current system the avail memory was truncated
when parsing the meminfo data, which made HBM device
look like it only had a fraction of available memory.
Signed-off-by: Thomas Naughton [email protected]