Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up unique remote port number as the default #1007

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Set up unique remote port number as the default #1007

merged 4 commits into from
Feb 11, 2025

Conversation

kchilleri
Copy link
Collaborator

Changing default remote port number of '7777' to a unique number in the range of (7777, 16000) using the user's $UID number.

Note: This new unique port number still goes through the is_port_taken() and find_free_port() functions in beeflow/remote.py in case it happens to be taken.

@kchilleri kchilleri linked an issue Feb 10, 2025 that may be closed by this pull request
Replace remote_port = 7777 in config file with unique port number #988
Closed
@kchilleri kchilleri mentioned this pull request Feb 10, 2025
Open
@kchilleri kchilleri requested review from pagrubel and rstyd February 10, 2025 18:47
pagrubel
pagrubel approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@pagrubel pagrubel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and gives a unique port number when issuing beeflow config new

rstyd
rstyd approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@rstyd rstyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great approved! We might still want a backup plan later if that port is used when the remote API gets setup but that's another issue.

@rstyd rstyd merged commit a290b3b into develop Feb 11, 2025
5 of 6 checks passed
@kchilleri kchilleri deleted the issue988/create-unique-remote-port branch February 12, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstyd rstyd rstyd approved these changes

@pagrubel pagrubel pagrubel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace remote_port = 7777 in config file with unique port number
3 participants
@kchilleri @rstyd @pagrubel