Add Zhipu Qingliu Agent implementation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin7-1
added
P3
Martin7-1
reviewed
Jan 10, 2025
There was a problem hiding this comment.
@cuiwei1 Thank you!
- Could you please consider using
recordinstead of normal class On HTTP parameters and response objects. - If no, could you please remove all
finalin setters?
I do not dive deep into it. But could you please add more tests? (including positive and negative tests)
...ty-zhipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/ZhipuAssistantChatModel.java
Outdated
Show resolved
Hide resolved
...ty-zhipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/ZhipuAssistantChatModel.java
Outdated
Show resolved
Hide resolved
...unity-zhipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/ZhipuAssistantClient.java
Show resolved
Hide resolved
...ty-zhipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/ZhipuAssistantChatModel.java
Outdated
Show resolved
Hide resolved
...in/java/dev/langchain4j/community/model/zhipu/spi/ZhipuAssistantChatModelBuilderFactory.java
Outdated
Show resolved
Hide resolved
...ipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/assistant/AssistantBlockData.java
Outdated
Show resolved
Hide resolved
...ipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/assistant/AssistantBlockData.java
Outdated
Show resolved
Hide resolved
...ipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/assistant/AssistantBlockData.java
Outdated
Show resolved
Hide resolved
...y-zhipu-ai/src/main/java/dev/langchain4j/community/model/zhipu/assistant/ClientResponse.java
Show resolved
Hide resolved
...n/java/dev/langchain4j/community/model/zhipu/assistant/conversation/ConversationRequest.java
Show resolved
Hide resolved
|
And, could you please add some explanations on how to run the IT? |
In dev.langchain4j.community.model.zhipu.ZhipuAiAssistantIT, modify the appIdto the corresponding appId of the Zhipu Open Platform's intelligent agent for testing. I have been running it in our production environment for half a month, and it is working normally. |
…ain4j/community/model/zhipu/assistant/AssistantBlockData.java Agree. Co-authored-by: Martin7-1 <[email protected]>
…ain4j/community/model/zhipu/assistant/AssistantBlockData.java Co-authored-by: Martin7-1 <[email protected]>
…ain4j/community/model/zhipu/assistant/AssistantBlockData.java Co-authored-by: Martin7-1 <[email protected]>
…ain4j/community/model/zhipu/assistant/ClientResponse.java Co-authored-by: Martin7-1 <[email protected]>
…ain4j/community/model/zhipu/ZhipuAssistantChatModel.java Co-authored-by: Martin7-1 <[email protected]>
…ain4j/community/model/zhipu/ZhipuAssistantChatModel.java Co-authored-by: Martin7-1 <[email protected]>
…ain4j/community/model/zhipu/spi/ZhipuAssistantChatModelBuilderFactory.java Co-authored-by: Martin7-1 <[email protected]>
|
@Martin7-1 |
|
@cuiwei1 Thank you! There are some conversations which are hidden and are not resolved, could you please check? |
|
@Martin7-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #46 #49
document
Change
General checklist
Checklist for adding new maven module
pom.xmlandlangchain4j-community-bom/pom.xmlChecklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreITthat extends from eitherEmbeddingStoreITorEmbeddingStoreWithFilteringIT{NameOfIntegration}EmbeddingStoreRemovalITthat extends fromEmbeddingStoreWithRemovalITChecklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStoreworks correctly with the data persisted using the latest released version of LangChain4j