Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearXNG: Fixed issue with illegal URLs containing spaces #42

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

bnayfeh
Copy link
Contributor

@bnayfeh bnayfeh commented Dec 27, 2024

Issue

Closes #35

Change

Now encode any spaces in returned URLs

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit tests in all modules, and they are all green
  • I have manually run all integration tests in the module I have added/changed, and they are all green

Checklist for adding new maven module

  • I have added my new module in the root pom.xml and langchain4j-community-bom/pom.xml

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added a {NameOfIntegration}EmbeddingStoreRemovalIT that extends from EmbeddingStoreWithRemovalIT

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

@Martin7-1 Martin7-1 added this to the 1.0.0-alpha2 milestone Dec 28, 2024
@Martin7-1 Martin7-1 added bug Something isn't working P2 High priority theme: web search engine Issues/PRs related to web search engine labels Dec 28, 2024
@Martin7-1 Martin7-1 changed the title Fixed issue with illegal URLs containing spaces being returned by Sea… SearXNG: Fixed issue with illegal URLs containing spaces Dec 28, 2024
Copy link
Collaborator

@Martin7-1 Martin7-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnayfeh Thank you! I have run all ITs and they are all green.

@Martin7-1 Martin7-1 marked this pull request as ready for review December 28, 2024 07:13
@Martin7-1 Martin7-1 merged commit 3155af0 into langchain4j:main Dec 28, 2024
4 checks passed
@bnayfeh bnayfeh deleted the fix-urls branch December 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 High priority theme: web search engine Issues/PRs related to web search engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Searxng: URI illegal character
2 participants