-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spring boot starter of xinference #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alvinlee518 Thank you! I'm wondering if we could still use Testcontainers to do IT.
No hurry, will try to review it next week :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alvinlee518 Thank you!
There are three opinions:
- The Spring Boot starter lacks
resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
file. - Please add new module to
langchainj4-community-bom
. - I'm thinking about whether we should add
@ConditionalOnMissingBean
in every bea n definition, as users may want to register their custom bean. WDYT?
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
...pring-boot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java
Outdated
Show resolved
Hide resolved
use
|
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
…oot-starter/src/main/java/dev/langchain4j/community/xinference/spring/AutoConfig.java Co-authored-by: Martin7-1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alvinlee518 Great job! Thank you!
Issue
Closes #
Change
General checklist
Checklist for adding new maven module
pom.xml
andlangchain4j-community-bom/pom.xml
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
{NameOfIntegration}EmbeddingStoreRemovalIT
that extends fromEmbeddingStoreWithRemovalIT
Checklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStore
works correctly with the data persisted using the latest released version of LangChain4j