Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Typesense as EmbeddingStore #28

Closed

Conversation

Martin7-1
Copy link
Collaborator

Issue

Closes #27

Change

Integrate with Typesense as EmbeddingStore. Support filter and removal.

NOTE: Typesense filter is not case-sensitive, so the filter in Typesense does not work well. So the IT extends EmbeddingStoreIT right now.

Besides, Typesense does not support removeAll but suggest that remove all by query (i.e. by filter). It need further document.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit tests in all modules, and they are all green
  • I have manually run all integration tests in the module I have added/changed, and they are all green

Checklist for adding new maven module

  • I have added my new module in the root pom.xml and langchain4j-community-bom/pom.xml

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added a {NameOfIntegration}EmbeddingStoreRemovalIT that extends from EmbeddingStoreWithRemovalIT

@Martin7-1 Martin7-1 added enhancement New feature or request P3 Medium priority theme: embedding store Issues/PRs related to embedding store labels Dec 8, 2024
@Martin7-1 Martin7-1 force-pushed the integration-with-typesense branch from 106828d to 6f93278 Compare December 9, 2024 13:12
@Martin7-1 Martin7-1 closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 Medium priority theme: embedding store Issues/PRs related to embedding store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Integrate with Typesense as EmbeddingStore
1 participant