Fix evaluator errors #1538
Merged
Fix evaluator errors #1538
+47
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baskaryan
reviewed
Feb 27, 2025
| @@ -1005,7 +1007,7 @@ async def _run_single_evaluator(evaluator): | |||
| results=[ | |||
| EvaluationResult( | |||
| key=key, | |||
| source_run_id=run.id, | |||
There was a problem hiding this comment.
not sure i follow this bit, does source run not refer to the run being evaluated?
There was a problem hiding this comment.
yeah this is confusing. this is the run for the evaluator. basically the issue was that by setting it to the parent run, when you were in langsmith in the experiment view and clicked on a failed evaluator run (or what should have been the evaluator run) it just opened up the target run. This fixes that.
|
Tests failing are 429 errors from OpenAI, not actual errors |
baskaryan
approved these changes
Mar 3, 2025
| self, | ||
| run: Run, | ||
| example: Optional[Example] = None, | ||
| source_run_id: Optional[uuid.UUID] = None, |
There was a problem hiding this comment.
can we give this a diff name, like evaluator_run_id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.