Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config and docs update for deploying #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ric9176
Copy link

@ric9176 ric9176 commented Apr 10, 2024

Firstly, thanks for putting this repo out, it's great 😀

This PR address a few small things I found when experimenting with it, particularly deploying.

  1. The index name needs to be capitalized when using Weaviate otherwise it'll cause an error as the graphql schema that they use internally requires a capitalized name, if it's not given then it gets coerced, so if it's called langchain, in their generated schema that'd be Langchain and you'd get an error when querying. I've updated env examples and noted in the docs to avoid this.

  2. There's an env var used for the prod url (VERCEL_URL) that needs to be updated, it also needs the NEXT_PUBLIC prefix to make it automatically available on the client, I've updated it to NEXT_PUBLIC_VERCEL_URL and added to the frontend .env.example

  3. I haven't included this in the PR as I wasn't sure if the change is applicable for this repo. For the Vercel git hooks that enable auto deployment on merge to main to work correctly with turbo you'd need to update the turbo.json build outputs to: "outputs": ["**/dist/**", ".next/**", "!.next/cache/**"]. Then you could set deploymentEnabled to true in vercel.json or remove that file completely. Otherwise you run into a missing routes manifest issue with auto deploy.

Thanks again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant