generated from martinthomson/internet-draft-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKDF tweaks #100
Merged
Merged
HKDF tweaks #100
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c63ebd5
Specified the input params for HKDF. Closes #87
ounsworth fc23125
Ilari's comments
ounsworth 551b85c
Tweaks to HKDF. Thanks Ilari
ounsworth e71c69d
Tweak. Thanks Ilari
ounsworth 804955f
HKDF SHA256 vs 512
ounsworth 1c6c537
HKDF sha256 v 512
ounsworth b31f770
Tweaks to HKDF salt description
ounsworth 13bfd24
fix-lint
ounsworth c4c6b92
Tweak to HKDF Salt
ounsworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Input block size of SHA384 is 128 bytes (16 words of 8 bytes each).
(Not that it makes actual difference as HMAC would zero-extend the key anyway.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I need to actually go read FIPS 180-4 so that I don't continue getting this wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait. HKDF (RFC 5869) says:
And some of its test vectors have
salt = (0 octets)
, so maybe it's easier for me to do the same instead of trying to figure out the correct-width input? As you say, HKDF will internally handle this properly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilaril Can you please re-check that the current wording is ok?