Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23 : add Expression to docblock at Sql\Predicate\Predicate methods #171

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

samsonasik
Copy link
Member

Signed-off-by: Abdul Malik Ikhsan [email protected]

Q A
QA yes

Description

Re-create zendframework/zend-db#348 by @andreasschroth Fixes #23 . Original PR description:

Static analysis fails if an Expression object is passed to some methods, thus the updated docblock.

@weierophinney weierophinney added this to the 2.11.4 milestone Feb 19, 2021
@weierophinney weierophinney changed the base branch from master to 2.11.x February 20, 2021 18:48
@weierophinney weierophinney merged commit 5b59413 into laminas:2.11.x Feb 20, 2021
@samsonasik samsonasik deleted the fix-23 branch February 20, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Expression as allowed value to Predicate
2 participants