Add exclude_strict_matching configuration
#77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new feature named `exclude_strict_matching` which actually allows projects to exclude jobs based on partially matching values.
Examples:
```json
{
"additional_checks": [
{
"name": "Do whatever",
"job": {
"php": "*",
"dependencies": "*",
"command": "some command"
}
}
],
"exclude": [
{
"name": "Do whatever on PHP 8."
}
],
"exclude_strict_matching": false,
}
```
In projects with multiple PHP versions supported, starting from PHP 7.4, every job on PHP 8.0+ will be excluded.
Prior to this change, one had to add multiple excludes with all combinations of PHP version + dependencies.
Signed-off-by: Maximilian Bösing <[email protected]>
froschdesign
reviewed
Mar 3, 2022
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
feature/non-strict-exclusion
branch
from
4c8cd4d to
67f979a
Compare
internalsystemerror
requested changes
Apr 5, 2022
| @@ -271,7 +282,7 @@ export default function (config) { | |||
| .filter(function (job) { | |||
| let keep = true; | |||
| config.exclude.forEach(function (exclusion) { | |||
| keep = keep && ! excludeJob(job, exclusion); | |||
| keep = keep && ! excludeJob(job, exclusion, config.exclude_strict_matching); | |||
There was a problem hiding this comment.
I think you want a ! on the config.exclude_strict_matching here as if set to true, it sets strict_comparison to true inside excludeJob, which is the opposite of the intent.
There was a problem hiding this comment.
Looking at around line 254 of your version of this file, if the 3rd argument is true, then it will return early and won't allow loser matchings. Unless I've missed something (very possible) this appears to be the inverse of the intent.
|
Closing this in favor of the idea of #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new feature named
exclude_strict_matchingwhich actually allows projects to exclude jobs based on partially matching values.Examples:
{ "additional_checks": [ { "name": "Do whatever", "job": { "php": "*", "dependencies": "*", "command": "some command" } } ], "exclude": [ { "name": "Do whatever on PHP 8." } ], "exclude_strict_matching": false, }In projects with multiple PHP versions supported, starting from PHP 7.4, every job on PHP 8.0+ will be excluded.
Prior to this change, one had to add multiple excludes with all combinations of PHP version + dependencies.
Will add additional changes to address ideas posted by @Ocramius in #76 (comment)