Add swap() tests #152
Merged
Add swap() tests #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzn
reviewed
Nov 6, 2023
rcatalan98
reviewed
Nov 7, 2023
scripts/utility/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| This Readme explains the structure and process of passing the pool test cases from .sol to .cairo | |||
There was a problem hiding this comment.
Suggested change
| This Readme explains the structure and process of passing the pool test cases from .sol to .cairo | |
| This Readme explains the structure and process of passing the pool test cases from the original Uniswap Protocol to a compatible and more readable cairo structure. |
Also add a short explanation on why we are doing this.
rcatalan98
reviewed
Nov 7, 2023
rcatalan98
reviewed
Nov 7, 2023
| fn POOL_CASES() -> Array<PoolTestCase> { | ||
| array![ | ||
| PoolTestCase { | ||
| // description: 'low fee, 1:1 price, 2e18 max range liquidity', |
There was a problem hiding this comment.
Suggested change
| // description: 'low fee, 1:1 price, 2e18 max range liquidity', |
There was a problem hiding this comment.
all these are the pool case description, are we sure we want to delete them?
rcatalan98
reviewed
Nov 7, 2023
| ], | ||
| }, | ||
| PoolTestCase { | ||
| // description: 'medium fee, 1:1 price, 2e18 max range liquidity', |
There was a problem hiding this comment.
Suggested change
| // description: 'medium fee, 1:1 price, 2e18 max range liquidity', |
rcatalan98
reviewed
Nov 7, 2023
| ], | ||
| }, | ||
| PoolTestCase { | ||
| // description: 'high fee, 1:1 price, 2e18 max range liquidity', |
There was a problem hiding this comment.
Suggested change
| // description: 'high fee, 1:1 price, 2e18 max range liquidity', |
rcatalan98
reviewed
Nov 7, 2023
| ], | ||
| }, | ||
| PoolTestCase { | ||
| // description: 'medium fee, 10:1 price, 2e18 max range liquidity', |
There was a problem hiding this comment.
Suggested change
| // description: 'medium fee, 10:1 price, 2e18 max range liquidity', |
rcatalan98
reviewed
Nov 7, 2023
| ], | ||
| }, | ||
| PoolTestCase { | ||
| // description: 'medium fee, 1:10 price, 2e18 max range liquidity', |
There was a problem hiding this comment.
Suggested change
| // description: 'medium fee, 1:10 price, 2e18 max range liquidity', |
rcatalan98
reviewed
Nov 7, 2023
rcatalan98
reviewed
Nov 7, 2023
This was referenced Nov 9, 2023
dubzn
approved these changes
Nov 16, 2023
|
|
||
| fn SWAP_EXPECTED_RESULTS_POOL_1() -> Array<SwapExpectedResults> { | ||
| array
dpinones
reviewed
Nov 17, 2023
dpinones
approved these changes
Nov 17, 2023
Co-authored-by: Damián Piñones <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #149, adding a suite of tests for the swap() functionality.
This PR also solves issue #162 , as a pool test case was necesary to build the structure for testing the different pools
This PR also solves a minor bug found on scripts/local.rs , where the BUILD_PATH_PREFIX was incomplete