[GH-1027] Add game mode params per map #1032
Conversation
Nico-Sanchez
force-pushed
the
gh-1027-add-game-mode-params
branch
from
ad64d9a to
373afb5
Compare
Nico-Sanchez
changed the title
…ode in forms & controllers
…. Also add it's behavior
Nico-Sanchez
force-pushed
the
gh-1027-add-game-mode-params
branch
from
7989201 to
a3ea317
Compare
| @derive {Jason.Encoder, only: [:name, :zone_enabled, :bots_enabled, :match_duration_ms, :respawn_time_ms]} | ||
|
|
||
| schema "game_mode_configurations" do | ||
| field(:name, Ecto.Enum, values: [:battle_royale, :deathmatch]) |
There was a problem hiding this comment.
I'm not sure about this restriction here; maybe we could have another field for this (like a game mode type). However, we can leave it as it is
There was a problem hiding this comment.
Oh the field name is debatable. But being type or name, it could be an Ecto.Enum as it is or something else. Tell me your thoughts so we improve it if it doesn't work!
| schema "map_mode_params" do | ||
| field(:amount_of_players, :integer) | ||
| field(:deleted_at, :naive_datetime) | ||
| embeds_many(:solo_initial_positions, Position, on_replace: :delete) |
There was a problem hiding this comment.
I would add a validation here saying that the initial positions length should be equal to the amount of players
There was a problem hiding this comment.
Noted. I'll create an issue with all your feedback ❤️
| </span> | ||
| </div> | ||
|
|
||
| <.inputs_for :let={fp} field={f[:map_mode_params]}> |
There was a problem hiding this comment.
What do you of think of doing this?
Although it kinda expands the form 😆 .
If you think it is better, you can encapsulate the inputs for within an div with the flex flex-row classes
There was a problem hiding this comment.
Will do in a separate PR. Thanks!
| </span> | ||
| </div> | ||
|
|
||
| <div class="flex items-center justify-between gap-6"> |
There was a problem hiding this comment.
We can add an X button within every nested form, so we can delete an specific configuration and not the last one
There was a problem hiding this comment.
Alright. Let me know if it's done somewhere already so I can implement it faster 🚀
|
I'm getting an error when I try to create the initial positions in a new game mode |
The error wasn't at creation, it was at editing (update) time. |
Motivation
We can't support multiple configs for multiple game modes and/or maps.
Closes #1027
Summary of changes
How to test it?
Open the configurator (localhost:4100) and interact with every game mode form.
Disclaimer⚠️
This is the 1st step to achieve the game modes - maps configurations. This just adds the CRUD and forms, in a next iteration this will be used to serve the config to the client.
Checklist