Some fixes and logging

lambdaclass · Oct 15, 2024 · dd3c1bb · dd3c1bb
1 parent a18768f
commit dd3c1bb
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/lib/beacon_api/controllers/error_controller.ex b/lib/beacon_api/controllers/error_controller.ex
@@ -1,8 +1,10 @@
 defmodule BeaconApi.ErrorController do
+  require Logger
   use BeaconApi, :controller
 
   @spec bad_request(Plug.Conn.t(), binary()) :: Plug.Conn.t()
   def bad_request(conn, message) do
+    Logger.error("Bad request: #{message}, path: #{conn.request_path}")
     conn
     |> put_status(400)
     |> json(%{
@@ -13,6 +15,7 @@ defmodule BeaconApi.ErrorController do
 
   @spec not_found(Plug.Conn.t(), any) :: Plug.Conn.t()
   def not_found(conn, _params) do
+    Logger.error("Not found resource, path: #{conn.request_path}")
     conn
     |> put_status(404)
     |> json(%{
@@ -23,6 +26,7 @@ defmodule BeaconApi.ErrorController do
 
   @spec internal_error(Plug.Conn.t(), any) :: Plug.Conn.t()
   def internal_error(conn, _params) do
+    Logger.error("Internal server error, path: #{conn.request_path}")
     conn
     |> put_status(500)
     |> json(%{

diff --git a/lib/beacon_api/controllers/v1/beacon_controller.ex b/lib/beacon_api/controllers/v1/beacon_controller.ex
@@ -30,7 +30,7 @@ defmodule BeaconApi.V1.BeaconController do
     conn
     |> json(%{
       "data" => %{
-        "genesis_time" => StoreDb.fetch_genesis_time!(),
+        "genesis_time" => StoreDb.fetch_genesis_time!() |> Integer.to_string(),
         "genesis_validators_root" =>
           ChainSpec.get_genesis_validators_root() |> Utils.hex_encode(),
         "genesis_fork_version" => ChainSpec.get("GENESIS_FORK_VERSION") |> Utils.hex_encode()

diff --git a/lib/beacon_api/controllers/v1/node_controller.ex b/lib/beacon_api/controllers/v1/node_controller.ex
@@ -1,6 +1,7 @@
 defmodule BeaconApi.V1.NodeController do
   use BeaconApi, :controller
 
+  require Logger
   alias BeaconApi.ApiSpec
   alias BeaconApi.Utils
   alias LambdaEthereumConsensus.Beacon.SyncBlocks
@@ -28,6 +29,7 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec health(Plug.Conn.t(), any) :: Plug.Conn.t()
   def health(conn, _params) do
+    Logger.info("NODE: Health check")
     %{is_syncing: syncing?} = SyncBlocks.status()
     syncing_status = if syncing?, do: 206, else: 200
 
@@ -38,6 +40,7 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec identity(Plug.Conn.t(), any) :: Plug.Conn.t()
   def identity(conn, _params) do
+    Logger.info("NODE: Identity check")
     metadata = Metadata.get_metadata() |> Utils.to_json()
 
     %{
@@ -61,6 +64,7 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec version(Plug.Conn.t(), any) :: Plug.Conn.t()
   def version(conn, _params) do
+    Logger.info("NODE: Version check")
     version = Application.spec(:lambda_ethereum_consensus)[:vsn]
     arch = :erlang.system_info(:system_architecture)
 
@@ -74,6 +78,7 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec syncing(Plug.Conn.t(), any) :: Plug.Conn.t()
   def syncing(conn, _params) do
+    Logger.info("NODE: Syncing check")
     %{
       is_syncing: is_syncing,
       is_optimistic: is_optimistic,
@@ -93,6 +98,7 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec peers(Plug.Conn.t(), any) :: Plug.Conn.t()
   def peers(conn, _params) do
+    Logger.info("NODE: Peers check")
     # TODO: (#1325) This is a stub.
     conn
     |> json(%{