cleanup and removed diffs

lambdaclass · Oct 16, 2024 · 147200e · 147200e
1 parent 0ad9cd5
commit 147200e
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 51 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -146,7 +146,7 @@ jobs:
         context: .
         file: ./Dockerfile
         load: true # Important for building without pushing
-        
+
   smoke:
     name: Start and stop the node
     needs: [compile-native, download-beacon-node-oapi]

diff --git a/consensus-test.yaml b/consensus-test.yaml
diff --git a/lib/beacon_api/controllers/v1/config_controller.ex b/lib/beacon_api/controllers/v1/config_controller.ex
@@ -32,6 +32,8 @@ defmodule BeaconApi.V1.ConfigController do
   def open_api_operation(:get_spec),
     do: ApiSpec.spec().paths["/eth/v1/config/spec"].get
 
+  # TODO: This is still an incomplete implementation, it should return some constants
+  # along with the chain spec. It's enough for assertoor.
   @spec get_spec(Plug.Conn.t(), any) :: Plug.Conn.t()
   def get_spec(conn, _params), do: json(conn, %{"data" => chain_spec()})
 

diff --git a/lib/beacon_api/controllers/v1/node_controller.ex b/lib/beacon_api/controllers/v1/node_controller.ex
@@ -1,7 +1,6 @@
 defmodule BeaconApi.V1.NodeController do
   use BeaconApi, :controller
 
-  require Logger
   alias BeaconApi.ApiSpec
   alias BeaconApi.Utils
   alias LambdaEthereumConsensus.Beacon.SyncBlocks
@@ -29,7 +28,6 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec health(Plug.Conn.t(), any) :: Plug.Conn.t()
   def health(conn, _params) do
-    Logger.info("NODE: Health check")
     %{is_syncing: syncing?} = SyncBlocks.status()
     syncing_status = if syncing?, do: 206, else: 200
 
@@ -40,7 +38,6 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec identity(Plug.Conn.t(), any) :: Plug.Conn.t()
   def identity(conn, _params) do
-    Logger.info("NODE: Identity check")
     metadata = Metadata.get_metadata() |> Utils.to_json()
 
     %{
@@ -64,7 +61,6 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec version(Plug.Conn.t(), any) :: Plug.Conn.t()
   def version(conn, _params) do
-    Logger.info("NODE: Version check")
     version = Application.spec(:lambda_ethereum_consensus)[:vsn]
     arch = :erlang.system_info(:system_architecture)
 
@@ -78,7 +74,6 @@ defmodule BeaconApi.V1.NodeController do
 
   @spec syncing(Plug.Conn.t(), any) :: Plug.Conn.t()
   def syncing(conn, _params) do
-    Logger.info("NODE: Syncing check")
     %{
       is_syncing: is_syncing,
       is_optimistic: is_optimistic,
@@ -95,17 +90,4 @@ defmodule BeaconApi.V1.NodeController do
       "sync_distance" => sync_distance |> Integer.to_string()
     }})
   end
-
-  @spec peers(Plug.Conn.t(), any) :: Plug.Conn.t()
-  def peers(conn, _params) do
-    Logger.info("NODE: Peers check")
-    # TODO: (#1325) This is a stub.
-    conn
-    |> json(%{
-      "data" => [%{}],
-      "meta" => %{
-        "count" => 0
-      }
-    })
-  end
 end