Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l1): add Deserialize trait for EIP4844Transaction #981

Merged

Conversation

h3lio5
Copy link
Contributor

@h3lio5 h3lio5 commented Oct 25, 2024

Motivation

Add the custom Deserialize trait for EIP4844Transaction.

Closes #882

@h3lio5 h3lio5 requested a review from a team as a code owner October 25, 2024 16:34
@h3lio5 h3lio5 changed the title Feat/eip4844 deserialize trait feat: add Deserialize trait for EIP4844Transaction Oct 25, 2024
@h3lio5 h3lio5 changed the title feat: add Deserialize trait for EIP4844Transaction feat(core): add Deserialize trait for EIP4844Transaction Oct 25, 2024
@h3lio5 h3lio5 changed the title feat(core): add Deserialize trait for EIP4844Transaction feat(EIP4844 TX): add Deserialize trait for EIP4844Transaction Oct 25, 2024
@h3lio5 h3lio5 changed the title feat(EIP4844 TX): add Deserialize trait for EIP4844Transaction feat(core): add Deserialize trait for EIP4844Transaction Oct 25, 2024
@h3lio5 h3lio5 changed the title feat(core): add Deserialize trait for EIP4844Transaction feat(l1): add Deserialize trait for EIP4844Transaction Oct 30, 2024
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit.

@fborello-lambda fborello-lambda added this pull request to the merge queue Oct 31, 2024
Merged via the queue into lambdaclass:main with commit 63e3efa Oct 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(EIP4844 TX): Implement custom Deserialization trait
2 participants