Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l2): standalone test for prover #969

Merged
merged 113 commits into from
Oct 31, 2024
Merged

feat(l2): standalone test for prover #969

merged 113 commits into from
Oct 31, 2024

Conversation

fborello-lambda
Copy link
Contributor

@fborello-lambda fborello-lambda commented Oct 24, 2024 •
edited
Loading

Motivation

There is a need to run the zkVMs efficiently and quickly to perform time measurements for performance estimations.

Description

The PR adds:

  • Standalone test for the prover.
  • CI for the prover running the test in dev mode - No Proof Generation.

Closes #968

fborello-lambda and others added 30 commits October 16, 2024 17:11
@fborello-lambda
add libmdbx features
45c9a95
@fborello-lambda
bump-up versions
0b6658b
@fborello-lambda
add de/serialization for Block and Transaction
b154097
@xqft
add zkvm program ci job
ab231dd
@xqft
misc fixes on ci job
8957079
@xqft
change names ci jobs
330177c
@fborello-lambda
wip: add basic structure
88d0f71
@fborello-lambda
fix: run tests with no-default-features
cf4d670
@fborello-lambda
Merge branch 'l2/prover_integration' into l2/prover_base
6a794f2
@fborello-lambda
add de/serialization for Receipt
518c30d
@fborello-lambda
Merge branch 'l2/prover_integration' into l2/prover_base
0703ce6
@xqft
Revert "change names ci jobs"
687619c 
This reverts commit 330177c.
@xqft
fix prover job
33db110
@xqft
fix job binary path
2190010
@xqft
fix cargo prove
1604131
@xqft
nit
0312121
@fborello-lambda
add prover crate to workspace
4d01428
@fborello-lambda
fix: rm clone
f49e67e
@fborello-lambda
fix: replace todo! with custom error
408e256
@fborello-lambda
rm derive Deserialize for EIP1559
056094d
@xqft
refactor transactions deser and derive deserialize on enum
e573135
@xqft
Revert "refactor transactions deser and derive deserialize on enum"
7f0f7e8 
This reverts commit e573135.
@xqft
refactor transactions deser and derive deserialize on enum
24bc2d2
@fborello-lambda
rm underscore form path variable
702c11b
@fborello-lambda
add missing Serialize impl for EIP1559
2698e5b
@fborello-lambda
Merge branch 'l2/prover_integration' into l2/prover_base
6ecac43
@fborello-lambda
wip
980fea6
@xqft
Merge branch 'main' into l2/prover_base
bbb3976
@fborello-lambda
[wip] run prover with ethereum_rust_l2 cli
ce5c073
@fborello-lambda
integrate prover's client with existing setup
c1498ab
@fborello-lambda fborello-lambda marked this pull request as ready for review October 28, 2024 17:30
@fborello-lambda fborello-lambda requested a review from a team as a code owner October 28, 2024 17:30
Base automatically changed from l2/integrate_cache_db to main October 31, 2024 14:23
@jrchatruc
Copy link
Collaborator

jrchatruc commented Oct 31, 2024 •
edited
Loading

Looks like the added CI workflow is being run twice because there's both a rule to run on every PR and one to run on pushes to branches starting with l2, etc. Let's change the rule to push to be just main, i.e.

push:
    branches: [main]

@jrchatruc jrchatruc added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 4c18bd4 Oct 31, 2024
19 checks passed
@jrchatruc jrchatruc deleted the l2/standalone_zkvm_test branch October 31, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@fborello-lambda fborello-lambda

Labels
L2
Projects
ethrex_l2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L2: (Prover) test performance
3 participants
@fborello-lambda @jrchatruc @xqft