Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l2): refactor L1 deployment script #954

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Conversation

ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Oct 23, 2024

Motivation

In the project's early stages, we relied on Foundry for contract deployment for simplicity. At this stage of the project, Foundry is not needed anymore.

Description

  • It adds the binary ethereum_rust_l2_l1_deployer, which when executed, compiles and deploys the L1 contracts using CREATE2.
  • Abstracts and integrates the call, send, and deploy logic to the EthClient in the eth_sender module.

@ilitteri ilitteri added the L2 label Oct 23, 2024
@ilitteri ilitteri added this to the [L2] 1 - Basic L2 milestone Oct 23, 2024
@ilitteri ilitteri self-assigned this Oct 23, 2024
@ilitteri ilitteri marked this pull request as ready for review October 24, 2024 16:00
@ilitteri ilitteri requested a review from a team as a code owner October 24, 2024 16:00
Copy link
Contributor

@fborello-lambda fborello-lambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the env variables needed to deploy the contracts in the .example.env file. And also fixed the clippy warnings.

@ilitteri ilitteri added this pull request to the merge queue Oct 24, 2024
@ilitteri ilitteri removed this pull request from the merge queue due to a manual request Oct 24, 2024
@ilitteri ilitteri added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit b1b2810 Oct 24, 2024
11 checks passed
@ilitteri ilitteri deleted the refactor_l1_deployment_script branch October 24, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants