feat(l2): withdrawal handling #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
reviewed
Oct 21, 2024
jrchatruc
reviewed
Oct 21, 2024
…to l2_withdrawal_handling
**Motivation** <!-- Why does this pull request exist? What are its goals? --> To complete the withdrawal flow **Description** - [Add openzeppelin-contracts dep installation](a23066b) - [Implement withdrawals in CommonBridge](165d1e8) - [Update ICommonBridge](57c3aca) - [Implement commit method in OnChainProposer](1901220) - [Update IOnChainProposer with new commit def](58010b9) - [Update deploy script](73d2b8f)
**Motivation** <!-- Why does this pull request exist? What are its goals? --> The proposer must be adapted to the new withdraw flow. This is just updating the input for the call to the `commit` method of the `OnChainProposer` when the proposer commits to a new block execution. **Description** <!-- A clear and concise general description of the changes this PR introduces --> - [Updates input for commit](7766201) - [Makes state_trie public](3cb4ada)
**Motivation** <!-- Why does this pull request exist? What are its goals? --> We need withdrawal logs merkle root to send to the L1 contract **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> --------- Co-authored-by: ilitteri <[email protected]>
**Motivation** <!-- Why does this pull request exist? What are its goals? --> We need a way to get the merkle path of the withdrawals so we can send them to the L1 contract. **Description** <!-- A clear and concise general description of the changes this PR introduces --> Add a command to the CLI to get a merkle path from a tx hash <!-- Link to issues: Resolves #111, Resolves #222 -->
…to l2_withdrawal_handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Withdrawals are an essential requirement for L2 networks.
Description
We introduce a new EIP-2718 transaction type called
PrivilegedL2Transactionused to manage deposits and withdraws. Handlers were set to the VM so when this transactions get executed, it runs custom logic like minting or burning ETH.Different CLI commands were also introduced to easily create and send this transactions.
Closes #816
Closes #839