-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(core): fix use of c-kzg
flag and cleanup dependencies
#1927
Conversation
Total lines added: 0 |
…to only-build-ethrex-default
|
@@ -1,30 +1,30 @@ | |||
[workspace] | |||
members = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reorder alphabetically
Benchmark Results ComparisonPR ResultsBenchmark Results: Factorial
Benchmark Results: Factorial - Recursive
Benchmark Results: Fibonacci
Benchmark Results: ManyHashes
Benchmark Results: BubbleSort
Benchmark Results: ERC20 - Transfer
Benchmark Results: ERC20 - Mint
Benchmark Results: ERC20 - Approval
Main ResultsBenchmark Results: Factorial
Benchmark Results: Factorial - Recursive
Benchmark Results: Fibonacci
Benchmark Results: ManyHashes
Benchmark Results: BubbleSort
Benchmark Results: ERC20 - Transfer
Benchmark Results: ERC20 - Mint
Benchmark Results: ERC20 - Approval
|
c-kzg
flag and cleanup dependencies
…to only-build-ethrex-default
…to only-build-ethrex-default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally 🚀 .
Motivation
We were having to add dependencies with
default-features = false
everywhere, which also didn't scale, since if one dependency adds the flag, it is added everywhere. We need to disable certain flags to be able to prove with ZK.Description
cmd/ethrex
as the default when running cargo build.c-kzg
as a default flag in our crates. Added them to the commands that require them: ethrex, ef_tests