Disable unnecessary features of zip dependency
#1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've discovered that using the `cairo-vm` crate in our projects brings in a lot of unnecessary dependencies and in the end leads to our binary being linked with the `libbz2` library. Turns out that neither of these is actually required and this happens because the `zip` crate has a large number of features enabled by default. This change disables all `zip` features except `deflate` which the code actually uses.
kkovaacs
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
Oppen
approved these changes
Sep 3, 2024
pefontana
approved these changes
Sep 3, 2024
ftheirs
pushed a commit
to ftheirs/cairo-vm
that referenced
this pull request
Sep 11, 2024
We've discovered that using the `cairo-vm` crate in our projects brings in a lot of unnecessary dependencies and in the end leads to our binary being linked with the `libbz2` library. Turns out that neither of these is actually required and this happens because the `zip` crate has a large number of features enabled by default. This change disables all `zip` features except `deflate` which the code actually uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discovered that using the
cairo-vmcrate in our projects brings in a lot of unnecessary dependencies and in the end leads to our binary being linked with thelibbz2library.Turns out that neither of these is actually required and this happens because the
zipcrate has a large number of features enabled by default.This change disables all
zipfeatures exceptdeflatewhich the code actually uses.