Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation label to changelog workflow skiplist #1619

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Feb 9, 2024

There is no reason for documentation updates to be reflected in the changelog

@fmoletta fmoletta changed the title Add docs label to changelog workflow skiplist Add documentation label to changelog workflow skiplist Feb 9, 2024
@fmoletta fmoletta added the pipelines This PR/issue is exclusively about improving our CI label Feb 9, 2024
@fmoletta fmoletta marked this pull request as ready for review February 9, 2024 20:51
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f98fef) 97.72% compared to head (4c1ea3c) 97.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          91       91           
  Lines       37278    37278           
=======================================
  Hits        36429    36429           
  Misses        849      849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 9, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.275 ± 0.038 2.235 2.359 1.00
head big_factorial 2.282 ± 0.027 2.244 2.352 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.255 ± 0.017 2.235 2.278 1.02 ± 0.01
head big_fibonacci 2.215 ± 0.014 2.197 2.231 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.637 ± 0.335 8.415 9.462 1.00 ± 0.05
head blake2s_integration_benchmark 8.605 ± 0.289 8.400 9.318 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.321 ± 0.011 2.297 2.331 1.00
head compare_arrays_200000 2.331 ± 0.016 2.308 2.358 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.446 ± 0.006 1.436 1.453 1.00 ± 0.01
head dict_integration_benchmark 1.444 ± 0.008 1.432 1.457 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.393 ± 0.007 1.382 1.406 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.391 ± 0.014 1.375 1.425 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.459 ± 0.063 8.381 8.553 1.00 ± 0.01
head integration_builtins 8.437 ± 0.055 8.365 8.534 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.754 ± 0.068 8.651 8.816 1.00 ± 0.01
head keccak_integration_benchmark 8.718 ± 0.053 8.655 8.814 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.346 ± 0.020 2.322 2.379 1.01 ± 0.02
head linear_search 2.334 ± 0.032 2.309 2.422 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.807 ± 0.009 1.794 1.818 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.801 ± 0.006 1.793 1.809 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.615 ± 0.025 1.584 1.663 1.00 ± 0.02
head math_integration_benchmark 1.614 ± 0.020 1.596 1.665 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.263 ± 0.011 1.249 1.284 1.00
head memory_integration_benchmark 1.266 ± 0.005 1.258 1.273 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.894 ± 0.011 1.881 1.914 1.00
head operations_with_data_structures_benchmarks 1.912 ± 0.023 1.896 1.976 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 594.8 ± 2.4 590.6 598.0 1.00
head pedersen 596.1 ± 2.4 592.5 600.7 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 995.7 ± 11.5 982.2 1015.8 1.01 ± 0.01
head poseidon_integration_benchmark 984.6 ± 8.6 969.2 994.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.929 ± 0.004 1.919 1.936 1.00
head secp_integration_benchmark 1.929 ± 0.009 1.917 1.948 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 724.4 ± 5.1 716.5 731.5 1.00
head set_integration_benchmark 729.4 ± 3.0 725.4 734.4 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.690 ± 0.109 4.615 4.987 1.00
head uint256_integration_benchmark 4.697 ± 0.102 4.605 4.893 1.00 ± 0.03

@pefontana pefontana added documentation Improvements or additions to documentation and removed pipelines This PR/issue is exclusively about improving our CI labels Feb 15, 2024
@Oppen Oppen added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit f1d2ec7 Feb 19, 2024
52 checks passed
@Oppen Oppen deleted the skip-changelog-workflow-on-docs-label branch February 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants