Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1618

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Update README.md #1618

merged 1 commit into from
Feb 19, 2024

Conversation

avilagaston9
Copy link
Contributor

Update README.md

Description

Updates the README file to reflect the migration of Cairo VM to the latest implementation in Rust.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Updates the README file to reflect the migration of Cairo VM to the latest implementation in Rust.
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b28f22d) 97.16% compared to head (fa47a66) 97.16%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1618   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          92       92           
  Lines       37369    37369           
=======================================
  Hits        36309    36309           
  Misses       1060     1060           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 9, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.318 ± 0.027 2.293 2.377 1.01 ± 0.01
head big_factorial 2.298 ± 0.020 2.276 2.347 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.291 ± 0.020 2.272 2.325 1.00 ± 0.01
head big_fibonacci 2.283 ± 0.012 2.267 2.310 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.312 ± 0.084 8.233 8.442 1.00 ± 0.01
head blake2s_integration_benchmark 8.277 ± 0.077 8.221 8.424 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.330 ± 0.018 2.308 2.360 1.00 ± 0.01
head compare_arrays_200000 2.320 ± 0.018 2.298 2.355 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.474 ± 0.007 1.468 1.488 1.01 ± 0.01
head dict_integration_benchmark 1.466 ± 0.021 1.452 1.519 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.296 ± 0.007 1.289 1.313 1.00
head field_arithmetic_get_square_benchmark 1.298 ± 0.013 1.283 1.321 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.320 ± 0.077 8.257 8.455 1.00 ± 0.01
head integration_builtins 8.296 ± 0.068 8.238 8.481 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.667 ± 0.090 8.582 8.850 1.00
head keccak_integration_benchmark 8.667 ± 0.105 8.535 8.794 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.379 ± 0.019 2.358 2.412 1.01 ± 0.01
head linear_search 2.358 ± 0.015 2.341 2.381 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.603 ± 0.008 1.594 1.619 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.590 ± 0.006 1.584 1.598 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.465 ± 0.005 1.460 1.474 1.01 ± 0.01
head math_integration_benchmark 1.449 ± 0.008 1.439 1.467 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.277 ± 0.006 1.271 1.287 1.00
head memory_integration_benchmark 1.279 ± 0.008 1.266 1.289 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.634 ± 0.007 1.625 1.648 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.624 ± 0.013 1.612 1.655 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 609.1 ± 1.9 606.6 612.2 1.00 ± 0.00
head pedersen 608.2 ± 2.1 605.4 612.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.067 ± 0.005 1.063 1.081 1.00
head poseidon_integration_benchmark 1.068 ± 0.004 1.064 1.077 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.938 ± 0.009 1.930 1.955 1.00
head secp_integration_benchmark 1.949 ± 0.009 1.938 1.964 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 776.2 ± 1.4 774.1 778.5 1.00 ± 0.00
head set_integration_benchmark 775.9 ± 3.0 771.3 782.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.618 ± 0.038 4.577 4.675 1.00 ± 0.01
head uint256_integration_benchmark 4.612 ± 0.038 4.559 4.653 1.00

@avilagaston9 avilagaston9 added the pipelines This PR/issue is exclusively about improving our CI label Feb 15, 2024
@Oppen Oppen added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 6101b05 Feb 19, 2024
50 of 51 checks passed
@Oppen Oppen deleted the update-readme branch February 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants