-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use locked dependencies to install cargo-nextest
& wasm-pack
#1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-nextest
cargo-nextest
& wasm-pack
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 92 92
Lines 37369 37369
=======================================
Hits 36309 36309
Misses 1060 1060 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
juanbono
approved these changes
Feb 9, 2024
pefontana
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation of
cargo-nextest
is currently failing (both locally & in thefresh-run
CI workflow) as one of it's dependencies has been updated to no longer be compatible with rust version lower than 1.74.This PR solves this issue by passing the
--locked
flag when installingcargo-nextest
in order to force the versions in theCargo.lock
to be used, with an older version of the dependency that is compatible with rust 1.70.This is also the case for
wasm-pack
.Closes #1613
Closes #1612