Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin genco-macros dependency to last working minor version #1471

Closed
wants to merge 2 commits into from

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Nov 6, 2023

The latest minor version update of the crate genco-macros used by cairo-lang crates is broken, and we therefore need to pin it to the previous version for cairo-vm to build propperly. This is a temporary fix until this issue is solved

@fmoletta fmoletta added the pipelines This PR/issue is exclusively about improving our CI label Nov 6, 2023
@fmoletta fmoletta marked this pull request as ready for review November 6, 2023 13:40
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1471 (4bd5123) into main (0d41042) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1471   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          95       95           
  Lines       39451    39451           
=======================================
  Hits        38199    38199           
  Misses       1252     1252           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

github-actions bot commented Nov 6, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 5.473 ± 0.083 5.379 5.616 1.00
head big_factorial 5.580 ± 0.110 5.447 5.842 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.735 ± 0.134 4.536 4.958 1.01 ± 0.04
head big_fibonacci 4.696 ± 0.155 4.519 5.076 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 12.006 ± 0.188 11.777 12.383 1.00
head blake2s_integration_benchmark 12.026 ± 0.281 11.794 12.621 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.666 ± 0.112 4.526 4.844 1.00 ± 0.03
head compare_arrays_200000 4.657 ± 0.116 4.500 4.807 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.116 ± 0.018 3.087 3.142 1.00
head dict_integration_benchmark 3.143 ± 0.054 3.077 3.224 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.028 ± 0.028 1.990 2.075 1.00
head field_arithmetic_get_square_benchmark 2.060 ± 0.073 1.995 2.251 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.939 ± 0.277 11.574 12.523 1.00
head integration_builtins 12.006 ± 0.242 11.563 12.331 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 12.140 ± 0.113 12.036 12.428 1.00
head keccak_integration_benchmark 12.448 ± 0.202 12.185 12.881 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.543 ± 0.037 4.496 4.600 1.00
head linear_search 4.554 ± 0.049 4.498 4.673 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.340 ± 0.048 3.268 3.428 1.00
head math_cmp_and_pow_integration_benchmark 3.350 ± 0.052 3.269 3.468 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.144 ± 0.049 3.066 3.212 1.00
head math_integration_benchmark 3.149 ± 0.037 3.102 3.202 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.673 ± 0.028 2.627 2.704 1.00
head memory_integration_benchmark 2.719 ± 0.059 2.646 2.795 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.945 ± 0.046 2.884 3.010 1.03 ± 0.02
head operations_with_data_structures_benchmarks 2.872 ± 0.033 2.803 2.916 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.056 ± 0.012 1.036 1.071 1.00
head pedersen 1.076 ± 0.044 1.044 1.196 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 2.017 ± 0.020 1.986 2.050 1.00
head poseidon_integration_benchmark 2.037 ± 0.039 1.986 2.119 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 4.062 ± 0.116 3.883 4.234 1.01 ± 0.04
head secp_integration_benchmark 4.024 ± 0.115 3.828 4.166 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.459 ± 0.067 2.376 2.559 1.00
head set_integration_benchmark 2.481 ± 0.051 2.372 2.569 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.796 ± 0.094 7.670 7.930 1.01 ± 0.02
head uint256_integration_benchmark 7.717 ± 0.125 7.537 7.975 1.00

@fmoletta fmoletta closed this Nov 6, 2023
@fmoletta fmoletta deleted the pin-genco-version branch November 6, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants