Use starknet-types-core Felt

.github/workflows/publish.yml

@@ -14,14 +14,6 @@ jobs:
       uses: actions/checkout@v2
     - name: Install stable toolchain
       uses: dtolnay/[email protected]
-    - name: Publish crate cairo-felt
-      env:
-          CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
-      run: cargo publish --token ${CRATES_TOKEN} --all-features --manifest-path ./felt/Cargo.toml
-    # FIXME: there should be a better way to make sure the index in crates.io is updated before publishing
-    # cairo-vm but right now the step throws timeout and fails. 
-    - name: wait for index in crates.io
-      run: sleep 300
     - name: Publish crate cairo-vm
       env:
           CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}

.github/workflows/rust.yml

@@ -187,12 +187,6 @@ jobs:
         fail-on-cache-miss: true
 
     # NOTE: we do this separately because --workspace operates in weird ways
-    - name: Check all features (felt)
-      run: |
-        cd felt
-        cargo check-all-features
-        cargo check-all-features --workspace --all-targets
-
     - name: Check all features (vm)
       run: |
         cd vm
@@ -218,7 +212,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        special_features: ["", "lambdaworks-felt", "extensive_hints"]
+        special_features: ["", "extensive_hints"]
         target: [ test#1, test#2, test#3, test#4, test-no_std#1, test-no_std#2, test-no_std#3, test-no_std#4, test-wasm ]
     name: Run tests
     runs-on: ubuntu-22.04
@@ -445,38 +439,38 @@ jobs:
         path: lcov-test-no_std-.info
         key: codecov-cache-test-no_std--${{ github.sha }}
         fail-on-cache-miss: true
-
-    - name: Fetch results for tests with stdlib (w/lambdaworks; part. 1)
+    - name: Fetch results for tests with stdlib (w/extensive_hints; part. 1)
       uses: actions/cache/restore@v3
       with:
-        path: lcov-test#1-lambdaworks-felt.info
-        key: codecov-cache-test#1-lambdaworks-felt-${{ github.sha }}
+        path: lcov-test#1-extensive_hints.info
+        key: codecov-cache-test#1-extensive_hints-${{ github.sha }}
         fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/lambdaworks; part. 2)
+    - name: Fetch results for tests with stdlib (w/extensive_hints; part. 2)
       uses: actions/cache/restore@v3
       with:
-        path: lcov-test#2-lambdaworks-felt.info
-        key: codecov-cache-test#2-lambdaworks-felt-${{ github.sha }}
+        path: lcov-test#2-extensive_hints.info
+        key: codecov-cache-test#2-extensive_hints-${{ github.sha }}
         fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/lambdaworks; part. 3)
+    - name: Fetch results for tests with stdlib (w/extensive_hints; part. 3)
       uses: actions/cache/restore@v3
       with:
-        path: lcov-test#3-lambdaworks-felt.info
-        key: codecov-cache-test#3-lambdaworks-felt-${{ github.sha }}
+        path: lcov-test#3-extensive_hints.info
+        key: codecov-cache-test#3-extensive_hints-${{ github.sha }}
         fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/lambdaworks; part. 4)
+    - name: Fetch results for tests with stdlib (w/extensive_hints; part. 4)
       uses: actions/cache/restore@v3
       with:
-        path: lcov-test#4-lambdaworks-felt.info
-        key: codecov-cache-test#4-lambdaworks-felt-${{ github.sha }}
+        path: lcov-test#4-extensive_hints.info
+        key: codecov-cache-test#4-extensive_hints-${{ github.sha }}
         fail-on-cache-miss: true
-    - name: Fetch results for tests without stdlib (w/lambdaworks)
+    - name: Fetch results for tests without stdlib (w/extensive_hints)
       uses: actions/cache/restore@v3
       with:
-        path: lcov-test-no_std-lambdaworks-felt.info
-        key: codecov-cache-test-no_std-lambdaworks-felt-${{ github.sha }}
+        path: lcov-no_std-extensive_hints.info
+        key: codecov-cache-test-no_std-extensive_hints-${{ github.sha }}
         fail-on-cache-miss: true
 
+
     - name: Upload coverage to codecov.io
       uses: codecov/codecov-action@v3
       with:

CHANGELOG.md

@@ -2,7 +2,9 @@
 
 #### Upcoming Changes
 
-* feat/BREAKING: Add Cairo 1 proof mode compilation and execution [#1517] (https://github.com/lambdaclass/cairo-vm/pull/1517)
+* feat(BREAKING): Replace `cairo-felt` crate with `starknet-types-core` [#1408](https://github.com/lambdaclass/cairo-vm/pull/1408)
+
+* feat(BREAKING): Add Cairo 1 proof mode compilation and execution [#1517] (https://github.com/lambdaclass/cairo-vm/pull/1517)
     * In the cairo1-run crate, now the Cairo 1 Programs are compiled and executed in proof-mode
     * BREAKING: Remove `CairoRunner.proof_mode: bool` field and replace it with `CairoRunner.runner_mode: RunnerMode`