Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: expose writer trait and common impls #1210

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 3 additions & 39 deletions cairo-vm-cli/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
#![deny(warnings)]
#![forbid(unsafe_code)]
use bincode::enc::write::Writer;
use cairo_vm::cairo_run::{self, EncodeTraceError};
use cairo_vm::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::BuiltinHintProcessor;
use cairo_vm::vm::errors::cairo_run_errors::CairoRunError;
use cairo_vm::vm::errors::trace_errors::TraceError;
use cairo_vm::vm::errors::vm_errors::VirtualMachineError;
use cairo_vm::write::BufWriter;
use clap::{Parser, ValueHint};
use std::io::{self, Write};
use std::path::PathBuf;
use thiserror::Error;

@@ -70,39 +69,6 @@ enum Error {
Trace(#[from] TraceError),
}

struct FileWriter {
buf_writer: io::BufWriter<std::fs::File>,
bytes_written: usize,
}

impl Writer for FileWriter {
fn write(&mut self, bytes: &[u8]) -> Result<(), bincode::error::EncodeError> {
self.buf_writer
.write_all(bytes)
.map_err(|e| bincode::error::EncodeError::Io {
inner: e,
index: self.bytes_written,
})?;

self.bytes_written += bytes.len();

Ok(())
}
}

impl FileWriter {
fn new(buf_writer: io::BufWriter<std::fs::File>) -> Self {
Self {
buf_writer,
bytes_written: 0,
}
}

fn flush(&mut self) -> io::Result<()> {
self.buf_writer.flush()
}
}

fn run(args: impl Iterator<Item = String>) -> Result<(), Error> {
let args = Args::try_parse_from(args);
let args = match args {
@@ -144,17 +110,15 @@ fn run(args: impl Iterator<Item = String>) -> Result<(), Error> {
let relocated_trace = vm.get_relocated_trace()?;

let trace_file = std::fs::File::create(trace_path)?;
let mut trace_writer =
FileWriter::new(io::BufWriter::with_capacity(3 * 1024 * 1024, trace_file));
let mut trace_writer = BufWriter::with_capacity(3 * 1024 * 1024, trace_file);

cairo_run::write_encoded_trace(relocated_trace, &mut trace_writer)?;
trace_writer.flush()?;
}

if let Some(memory_path) = args.memory_file {
let memory_file = std::fs::File::create(memory_path)?;
let mut memory_writer =
FileWriter::new(io::BufWriter::with_capacity(5 * 1024 * 1024, memory_file));
let mut memory_writer = BufWriter::with_capacity(5 * 1024 * 1024, memory_file);

cairo_run::write_encoded_memory(&cairo_runner.relocated_memory, &mut memory_writer)?;
memory_writer.flush()?;
2 changes: 1 addition & 1 deletion src/cairo_run.rs
Original file line number Diff line number Diff line change
@@ -7,9 +7,9 @@ use crate::{
security::verify_secure_runner,
vm_core::VirtualMachine,
},
write::Writer,
};

use bincode::enc::write::Writer;
use felt::Felt252;

#[cfg(feature = "std")]
85 changes: 85 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
@@ -48,6 +48,91 @@ mod stdlib {
pub use crate::without_std::*;
}

pub mod write {
pub use bincode::enc::write::SliceWriter;
pub use bincode::enc::write::Writer;
pub use bincode::error::EncodeError;

pub struct VecWriter {
buf: Vec<u8>,
}

impl VecWriter {
pub fn new() -> Self {
Self { buf: Vec::new() }
}

pub fn with_capacity(cap: usize) -> Self {
Self {
buf: Vec::with_capacity(cap),
}
}

pub fn as_slice(&self) -> &[u8] {
&self.buf
}
}

impl Writer for VecWriter {
fn write(&mut self, bytes: &[u8]) -> Result<(), bincode::error::EncodeError> {
self.buf.extend_from_slice(bytes);
Ok(())
}
}

impl Into<Vec<u8>> for VecWriter {
fn into(self) -> Vec<u8> {
self.buf
}
}

#[cfg(feature = "std")]
use std::io::Write;

#[cfg(feature = "std")]
pub struct BufWriter<T: Write> {
buf_writer: std::io::BufWriter<T>,
bytes_written: usize,
}

#[cfg(feature = "std")]
impl<T: Write> Writer for BufWriter<T> {
fn write(&mut self, bytes: &[u8]) -> Result<(), EncodeError> {
self.buf_writer
.write_all(bytes)
.map_err(|e| EncodeError::Io {
inner: e,
index: self.bytes_written,
})?;

self.bytes_written += bytes.len();

Ok(())
}
}

#[cfg(feature = "std")]
impl<T: Write> BufWriter<T> {
pub fn new(writer: T) -> Self {
Self {
buf_writer: std::io::BufWriter::new(writer),
bytes_written: 0,
}
}

pub fn with_capacity(cap: usize, writer: T) -> Self {
Self {
buf_writer: std::io::BufWriter::with_capacity(cap, writer),
bytes_written: 0,
}
}

pub fn flush(&mut self) -> std::io::Result<()> {
self.buf_writer.flush()
}
}
}

pub extern crate felt;
pub mod cairo_run;
pub mod hint_processor;