Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another bzlmod support PR 😆 #88

Closed
wants to merge 12 commits into from
Closed

Yet another bzlmod support PR 😆 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
462ecdc
Support Bazel Modules
jondo2010 Sep 12, 2023
ab93a2b
Added version
jondo2010 Sep 12, 2023
bc73623
Added test step with bzlmod enabled
jondo2010 Sep 15, 2023
0af1aa3
fixes
jondo2010 Sep 15, 2023
1dd69d7
Don't test w/ bzlmod for Bazel 5
lalten Oct 25, 2023
222c33d
multiple use_repos are not necessary
shabanzd Nov 20, 2023
ccd7019
Try to upgrade appimage to bzlmod in a backward compatible manner
shabanzd Nov 20, 2023
65e3aeb
register tool chain in module as well
ziad-fernride Dec 3, 2023
8685435
WORKSPACE.bzlmod making it act weird
ziad-fernride Dec 3, 2023
43f29c4
calling deps in MODULE.bazel no longer necessary
ziad-fernride Dec 3, 2023
7dca9fa
try to use the bazel version that seems to have solved the issue we a…
ziad-fernride Dec 3, 2023
35107b6
remove rules_python from MODULE.bazel
ziad-fernride Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ jobs:
- name: Run tests
run: bazel test --test_env=NO_CLEANUP=1 //...

- name: Run tests (bzlmod enabled)
if: ${{ matrix.bazel-version != '5.x' }}
run: bazel test --test_env=NO_CLEANUP=1 --enable_bzlmod //...

lint:
runs-on: ubuntu-latest
permissions:
Expand Down
5 changes: 5 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module(name = "rules_appimage", version = "1.2.0")

bazel_dep(name = "bazel_skylib", version = "1.4.2")
bazel_dep(name = "rules_cc", version = "0.0.9")
bazel_dep(name = "platforms", version = "0.0.7")
Loading