Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support root modules using python 3.8 #115

Merged
merged 2 commits into from
Jan 26, 2024
Merged

support root modules using python 3.8 #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9fe4c5
support root modules using python 3.8 etc
shabanzd Dec 24, 2023
22cd1da
Update BUILD
shabanzd Dec 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,32 @@ use_repo(

register_toolchains("//appimage:all")

PYTHON_VERSIONS = [
"3.8",
"3.9",
"3.10",
"3.11",
]
Comment on lines +26 to +31
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this have to match all the versions in
https://github.com/bazelbuild/rules_python/blob/4c2d7d9d6608795522322a9b2294b5053e41b979/python/versions.bzl#L47-L48

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, this is not really about toolchains. It is about pip wheels. The pip wheels need to be registered for all python versions to be supported. I am not sure if those wheels really care about the patch version of python.


python = use_extension("@rules_python//python/extensions:python.bzl", "python")
python.toolchain(python_version = "3.11")

[
python.toolchain(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this download all the actual Python toolchains to the repo cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully not 😂
If it does, I would assume it is a bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course here I am talking about the root module. The rules_appimage will hopefully not bring in any toolchain other than the one requested by the root module.

is_default = python_version == PYTHON_VERSIONS[-1],
python_version = python_version,
)
for python_version in PYTHON_VERSIONS
]

pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
pip.parse(
hub_name = "rules_appimage_py_deps",
python_version = "3.11",
requirements_lock = "//:requirements.txt",
)

[
pip.parse(
hub_name = "rules_appimage_py_deps",
python_version = python_version,
requirements_lock = "//:requirements.txt",
)
for python_version in PYTHON_VERSIONS
]
Comment on lines +45 to +52
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a change would have to be reflected in the WORKSPACE setup I think? The Bzlmod and Workspace implementations should not diverge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem does not exist in the WORKSPACE world since every dependency brings its own transitive dependency graph. Meaning that the WORKSPACE will always use python 3.11 (which is the default in the MODULE.bazel). I think that's close enough 😂

The problem is only in the bzlmod world, where only 1 transitive dependency graph is resolved for the entire project. Which is super cool, but comes with some costs.

I am not sure this PR is the only way to handle it, but I already saw some modules in the BCR that take this approach, and I find it logical.


use_repo(pip, "rules_appimage_py_deps")