Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating bourbon to v4.0.2 #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nickspiel
Copy link

Updating bourbon to v4.0.2.

It might be an idea to put this into a dev (or branch the current master) so people have the option to rollback if they are still using deprecated mixins.

Nick Spiel added 2 commits November 20, 2014 13:43
Selection mixin had syntax errors, rolling back untill stable.
@nickspiel
Copy link
Author

Ah, looks like the build is failing.

I have been looking into fixing this up for about an hour now. I'm not terribly familiar with JS automated tests but will give this another shot tonight and see if I can fix it up.

@nickspiel
Copy link
Author

In my adventures trying to bring this up to speed I encountered another issue with the font-face-declaration. The font src is output surrounded by quotes which is being called with the correct interpolation syntax. This works perfectly with the latest sass and bourbon outside of this module.

Is anyone able to point me into the right direction as to what might be causing the interpolation issue (other dependencies / files that may need to be updated etc)?

I posted a question on stackoverflow but am not getting any love... :(

http://stackoverflow.com/questions/27032685/bourbon-font-face-outputting-src-surrounded-by-quotes

@iamlacroix iamlacroix force-pushed the master branch 2 times, most recently from a042dd1 to 3cf5308 Compare April 30, 2015 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant